From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC846C25B06 for ; Sun, 14 Aug 2022 09:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbiHNJvF (ORCPT ); Sun, 14 Aug 2022 05:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiHNJvF (ORCPT ); Sun, 14 Aug 2022 05:51:05 -0400 X-Greylist: delayed 349 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 14 Aug 2022 02:51:04 PDT Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76990192BF for ; Sun, 14 Aug 2022 02:51:04 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A524B2B05FDE; Sun, 14 Aug 2022 05:45:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 14 Aug 2022 05:45:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1660470310; x=1660477510; bh=FdFP/H49+r ZQsPEMoSpH1blp96NX4j7NVyCsnlQOwKc=; b=qAarWNTRnx4c01YwaTDmDon3cT WoeRczFOoEi+9Yn59fFevm4BDrerzL8Qlujy0xfLMkyaoQfIjNfen2HFSFBZFB0Q XNoGICGJC2sUobGRe86muQFZE/cYsqOO0j6IYwB2CS835Qsq6BPjKB+oDCW1JO6C pvpC0Mrw3QJMLQBeUlYwEfqvZK9YB3kuH9EMynjrZLBo/InM0t4Q81pjJHfQ/p5C 0GtZsBGQ50dS2bXKJjx8WZiCTf9hqEWVJ5wm05nZnJc0C5bBQAUdT1VxX2j9oC6q rMDXsGcuxb3sCu+JA4QRd5t25AOxNytA3uK+r1ikFU+3ya5x2lNxSQ3uOUHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660470310; x=1660477510; bh=FdFP/H49+rZQsPEMoSpH1blp96NX 4j7NVyCsnlQOwKc=; b=WEq9wKKYIAAfYldO75VsevXwtHARcaxZHLAmNnNZOXvl wHUSsxEtGpaNN3dcgybyp8V9bC3iR+WQnHsnaCSZtbGUn7WqOOE+y88ew9CrEtx5 KccnnLpEFgx2sZNnrD+2QgNax+OUTUxes3cue/UpBUigm0LVysdKx6b2edhOsgZT mtz4CGcucgfqJpkzKvq1kD0ja/cYYzlwZt12b6/okBLPFIy7Zoi8WEKLybxgSkEn qIF4eT4qV55GGWIEmLBKV3yahBmceZa5NbIFCtOF0zUHfm5JHWY+3COP2i5veLeX /JfYijRGOvc4xZPuEv0vc7RWsguBIkKbVSYcmDGkGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehtddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 14 Aug 2022 05:45:09 -0400 (EDT) Date: Sun, 14 Aug 2022 11:45:06 +0200 From: Greg KH To: Khalid Masum Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Heikki Krogerus , "Rafael J . Wysocki" , Pierre-Louis Bossart , Daniel Scally , Vinod Koul , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Bard Liao , Len Brown Subject: Re: [RFC PATCH] Soundwire: Initialize multi_link with fwnode props Message-ID: References: <20220814080416.7531-1-khalid.masum.92@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220814080416.7531-1-khalid.masum.92@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sun, Aug 14, 2022 at 02:04:15PM +0600, Khalid Masum wrote: > According to the TODO, In sw_bus_master_add, bus->multi_link is to be > populated with properties from FW node props. Make this happen by > creating a new fwnode_handle flag FWNODE_FLAG_MULTI_LINKED and use > the flag to store the multi_link value from intel_link_startup. Use > this flag to initialize bus->multi_link. > > Signed-off-by: Khalid Masum > --- > I do not think adding a new flag for fwnode_handle is a good idea. > So, what would be the best way to initialize bus->multilink with > fwnode props? > > -- Khalid Masum > > drivers/soundwire/bus.c | 4 ++-- > drivers/soundwire/intel.c | 1 + > include/linux/fwnode.h | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index a2bfb0434a67..80df1672c60b 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -74,9 +74,9 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent, > > /* > * Initialize multi_link flag > - * TODO: populate this flag by reading property from FW node > */ > - bus->multi_link = false; > + bus->multi_link = (fwnode->flags & FWNODE_FLAG_MULTI_LINKED) > + == FWNODE_FLAG_MULTI_LINKED; > if (bus->ops->read_prop) { > ret = bus->ops->read_prop(bus); > if (ret < 0) { > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 505c5ef061e3..034d1c523ddf 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1347,6 +1347,7 @@ int intel_link_startup(struct auxiliary_device *auxdev) > */ > bus->multi_link = true; > bus->hw_sync_min_links = 1; > + dev->fwnode->flags |= FWNODE_FLAG_MULTI_LINKED; > } > > /* Initialize shim, controller */ > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index 9a81c4410b9f..446a52744953 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -32,6 +32,7 @@ struct device; > #define FWNODE_FLAG_NOT_DEVICE BIT(1) > #define FWNODE_FLAG_INITIALIZED BIT(2) > #define FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD BIT(3) > +#define FWNODE_FLAG_MULTI_LINKED BIT(4) What does this commit actually change? Did you test this on real hardware? thanks, greg k-h