From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
devel@acpica.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Elie Morisse <syniurge@gmail.com>,
Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
Khalil Blaiech <kblaiech@nvidia.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Mark Brown <broonie@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
Date: Thu, 8 Sep 2022 13:04:55 +0300 [thread overview]
Message-ID: <Yxm+R+x5zSTvDFrj@smile.fi.intel.com> (raw)
In-Reply-To: <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com>
On Thu, Sep 08, 2022 at 11:29:22AM +0200, Hans de Goede wrote:
> On 9/7/22 18:46, Andy Shevchenko wrote:
...
> > + long ret;
>
> "long ret" should be "int ret" here since that is what acpi_dev_uid_to_integer()
> returns.
I put it long since the efi_get_device_by_path() uses long ret (for the sake of
consistency with the existing code), but I have no objections to move it to
int.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-08 10:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 16:45 [PATCH v1 0/8] ACPI: unify _UID handling as integer Andy Shevchenko
2022-09-07 16:45 ` [PATCH v1 1/8] ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID " Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 2/8] ACPI: LPSS: Refactor _UID handling to use acpi_dev_uid_to_integer() Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 3/8] ACPI: x86: " Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 4/8] i2c: amd-mp2-plat: " Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 5/8] i2c: mlxbf: " Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 6/8] perf: qcom_l2_pmu: " Andy Shevchenko
2022-09-07 16:46 ` [PATCH v1 7/8] spi: pxa2xx: " Andy Shevchenko
2022-09-07 17:06 ` Mark Brown
2022-09-07 16:46 ` [PATCH v1 8/8] efi/dev-path-parser: " Andy Shevchenko
2022-09-08 8:20 ` Ard Biesheuvel
2022-09-08 10:06 ` Andy Shevchenko
2022-09-08 9:29 ` Hans de Goede
2022-09-08 10:04 ` Andy Shevchenko [this message]
2022-09-08 9:28 ` [PATCH v1 0/8] ACPI: unify _UID handling as integer Hans de Goede
2022-09-08 10:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxm+R+x5zSTvDFrj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=devel@acpica.org \
--cc=haojian.zhuang@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kblaiech@nvidia.com \
--cc=konrad.dybcio@somainline.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robert.moore@intel.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox