From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF6DC54EE9 for ; Thu, 8 Sep 2022 10:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbiIHKFI (ORCPT ); Thu, 8 Sep 2022 06:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiIHKFH (ORCPT ); Thu, 8 Sep 2022 06:05:07 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC2F9E8B2; Thu, 8 Sep 2022 03:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662631506; x=1694167506; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6Ek9wygy8aZWzMgiPRlm9cfMhpuOEUegAjyWFacJCV0=; b=kzKMbkSq4YUCxWQ7saoC0bjymdOKShvwuVQf5aF2xJu8x20EUQWj9PpV +CquM/sdd15/u9QVTK0ggJshpo4+MLHoj5q/oLDcHiExpnxtjoPoyXKmf h05t3ITz41VmrX4ZwYfHa3K6xoW+23WCf1dlAyo9HM02oCuKUjRt0xp3a Z+IceWTvZiryPvkTJ2l3XpfGifoV4KEwVVm0VhxX3Un2G0FuIbLrCVz5a xoJ1utYV4NitvWoQt7uAUl7J/ShFDux+8P5fo6003NdV1JFa4wljpdl09 j+Wf82o4/FiXgrUzXSsl2lY44sBK3rpZ5pl/XjQkG2D+E9w+k5KA9mnAV Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10463"; a="298465140" X-IronPort-AV: E=Sophos;i="5.93,299,1654585200"; d="scan'208";a="298465140" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2022 03:05:06 -0700 X-IronPort-AV: E=Sophos;i="5.93,299,1654585200"; d="scan'208";a="790383420" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2022 03:04:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oWEP1-00A4Oy-2z; Thu, 08 Sep 2022 13:04:55 +0300 Date: Thu, 8 Sep 2022 13:04:55 +0300 From: Andy Shevchenko To: Hans de Goede Cc: "Rafael J. Wysocki" , Wolfram Sang , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Ard Biesheuvel , Elie Morisse , Nehal Shah , Shyam Sundar S K , Khalil Blaiech , Andy Gross , Bjorn Andersson , Konrad Dybcio , Will Deacon , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , Robert Moore , Wolfram Sang Subject: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer() Message-ID: References: <20220907164606.65742-1-andriy.shevchenko@linux.intel.com> <20220907164606.65742-9-andriy.shevchenko@linux.intel.com> <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Sep 08, 2022 at 11:29:22AM +0200, Hans de Goede wrote: > On 9/7/22 18:46, Andy Shevchenko wrote: ... > > + long ret; > > "long ret" should be "int ret" here since that is what acpi_dev_uid_to_integer() > returns. I put it long since the efi_get_device_by_path() uses long ret (for the sake of consistency with the existing code), but I have no objections to move it to int. -- With Best Regards, Andy Shevchenko