From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH] ACPI: PCI: Rework acpi_get_pci_dev()
Date: Sat, 10 Sep 2022 16:06:04 +0200 [thread overview]
Message-ID: <YxyZzJkj4B1grGqK@kroah.com> (raw)
In-Reply-To: <2661914.mvXUDI8C0e@kreacher>
On Sat, Sep 10, 2022 at 03:23:46PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The PCI device returned by acpi_get_pci_dev() needs to be registered,
> so if it corresponds to an ACPI device object, the struct acpi_device
> representing that object must be registered too and, moreover, it
> should be the ACPI companion of the given PCI device. Thus it should
> be sufficient to look for it in the ACPI device object's list of
> physical nodes associated with it.
>
> Modify the code accordingly.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/acpi/pci_root.c | 81 ++++++++----------------------------------------
> 1 file changed, 15 insertions(+), 66 deletions(-)
Nice, less code is always better :)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2022-09-10 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 13:23 [PATCH] ACPI: PCI: Rework acpi_get_pci_dev() Rafael J. Wysocki
2022-09-10 14:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxyZzJkj4B1grGqK@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox