From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2 1/2] device property: Introduce fwnode_device_is_compatible() helper
Date: Thu, 6 Oct 2022 15:34:10 +0300 [thread overview]
Message-ID: <Yz7LQuf0L29cne3I@smile.fi.intel.com> (raw)
In-Reply-To: <Yz3xsmy/3wlntStv@paasikivi.fi.intel.com>
On Wed, Oct 05, 2022 at 09:05:54PM +0000, Sakari Ailus wrote:
> On Wed, Oct 05, 2022 at 06:29:46PM +0300, Andy Shevchenko wrote:
...
> fwnode_property_match_string() returns zero on success, therefore >= 0 is
> not needed. I'd just use !fwnode_property_match_string(...).
No, it's bug in the documentation, thanks to rising an attention,
I forgot to send a fix for it earlier.
> For both patches:
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks, but as stated above the condition in my patch is correct.
It seems due to documentation bug we have some kind of "buggy" code,
luckily not too many to fix.
That said, I'm not going to resend this until PPC (Freescale) maintainers
ask for it. Yang, what's your vision on this series?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-06 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 15:29 [PATCH v2 0/2] gpiolib: more cleanups to get rid of of_node Andy Shevchenko
2022-10-05 15:29 ` [PATCH v2 1/2] device property: Introduce fwnode_device_is_compatible() helper Andy Shevchenko
2022-10-05 21:05 ` Sakari Ailus
2022-10-06 12:34 ` Andy Shevchenko [this message]
2022-10-05 15:29 ` [PATCH v2 2/2] soc: fsl: qe: Switch to use fwnode instead of of_node Andy Shevchenko
2022-10-21 19:01 ` [PATCH v2 0/2] gpiolib: more cleanups to get rid " Andy Shevchenko
2022-11-02 11:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz7LQuf0L29cne3I@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=leoyang.li@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox