From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFBEC433FE for ; Tue, 4 Oct 2022 08:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbiJDIRL (ORCPT ); Tue, 4 Oct 2022 04:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230099AbiJDIQx (ORCPT ); Tue, 4 Oct 2022 04:16:53 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54279399DE; Tue, 4 Oct 2022 01:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664871348; x=1696407348; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lb4bSlvedpaQjVg5odfIx4IN7U+kZA4eNgmQRJpfroI=; b=P23mBDfO+uLz94rCQ0fCu5q7ZzpBPvqmJ26luZJPYx6BfayVrYFVPjcr t+cTuRYA6XUj/NpLzc6YcGWNkYyrFBSgxbPpDlmVtSOubzvzVavsZnFmf rX7/1qhS+LnO+hadgoc/mFiKSjlgwq5nRkcpHTb49zbT4u+AE+6ETptXc smkn9bT0BGl2D/PyhA2yixZFmaYUPA2bgvkMEwzGOP4WtIJSiUOlKqz/A 1Fl+jT/+WgzC9M7GQV1UX2TpJ1o5/JnloKRYeEmMAsZCLtL+PtigdF3BY X/fzmXeALrUtH9bmkjbY1eKBtXl3St6Ra1q8AXufOFXQEzemXwwp9dGjG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="364753558" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="364753558" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 01:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="692397954" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="692397954" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 04 Oct 2022 01:14:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ofd4A-001xvm-2X; Tue, 04 Oct 2022 11:14:14 +0300 Date: Tue, 4 Oct 2022 11:14:14 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Sakari Ailus , Heikki Krogerus , Bjorn Andersson , Prashant Malani , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Scally , "Rafael J. Wysocki" Subject: Re: [PATCH v2 1/5] device property: Keep dev_fwnode() and dev_fwnode_const() separate Message-ID: References: <20220928105746.51208-1-andriy.shevchenko@linux.intel.com> <20220928105746.51208-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Oct 04, 2022 at 09:55:21AM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 03, 2022 at 08:08:58PM +0000, Sakari Ailus wrote: > > On Mon, Oct 03, 2022 at 06:17:17PM +0200, Greg Kroah-Hartman wrote: ... > > #define kobj_to_dev(kobj) \ > > (_Generic((kobj), \ > > const struct kobject *: __kobj_to_dev_const, \ > > struct kobject *: __kobj_to_dev)(kobj)) > > Ah, doh! I had the (kobj) part in the wrong place, thanks for that > fix... > > Ok, this looks better, let me see how well the build breaks with some of > these changes I believe I can rewrite my patch like this and then it will be much nicer since we may constify all the rest without calling __dev_fwnode_const() directly. Are you agree? -- With Best Regards, Andy Shevchenko