From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA59C433FE for ; Tue, 4 Oct 2022 08:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbiJDI0H (ORCPT ); Tue, 4 Oct 2022 04:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiJDI0E (ORCPT ); Tue, 4 Oct 2022 04:26:04 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB8E22B12; Tue, 4 Oct 2022 01:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664871961; x=1696407961; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xFUr2CE7UnL6lwY/H1X/jHfUV8JBN2yFrKgPXcXepp8=; b=XwxblJojXcagw7MZJhb90l/4NaL5SRrq5y9gwYyM9AE6BPm71z+WpVrw /UQOTp3nw9JTIvTNZs3usmK6Bh82rgx6ervoozT7uTCs6FRXaL7h9I0PN CiUof5PDQ9v2ak47LUV2LAGfMXDV05ZWKWISB9g9hYGG0UjcW3ik7VIlq zIDnaJhWD64zb1qdfu7LOFa/EH4wwCNXMdvCDF+O3KTvGY3nZhLLfHQv+ zRMnCCqsx1sq2fYcA4AJ3S5IwpbAjnqta2NDEoR0obkoziPB8NdPxMIEn 6YskSD3qqOORZdcWIhNa5M/eVHKykPha3S5eceJp3rUSiAWIhqT1I0jeO Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="329260816" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="329260816" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 01:26:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="574952833" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="574952833" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 04 Oct 2022 01:25:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ofdFU-001yDG-1m; Tue, 04 Oct 2022 11:25:56 +0300 Date: Tue, 4 Oct 2022 11:25:56 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Sakari Ailus , Heikki Krogerus , Bjorn Andersson , Prashant Malani , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Scally , "Rafael J. Wysocki" Subject: Re: [PATCH v2 1/5] device property: Keep dev_fwnode() and dev_fwnode_const() separate Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Oct 04, 2022 at 10:24:13AM +0200, Greg Kroah-Hartman wrote: > On Tue, Oct 04, 2022 at 11:14:14AM +0300, Andy Shevchenko wrote: > > On Tue, Oct 04, 2022 at 09:55:21AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Oct 03, 2022 at 08:08:58PM +0000, Sakari Ailus wrote: > > > > On Mon, Oct 03, 2022 at 06:17:17PM +0200, Greg Kroah-Hartman wrote: ... > > > > #define kobj_to_dev(kobj) \ > > > > (_Generic((kobj), \ > > > > const struct kobject *: __kobj_to_dev_const, \ > > > > struct kobject *: __kobj_to_dev)(kobj)) > > > > > > Ah, doh! I had the (kobj) part in the wrong place, thanks for that > > > fix... > > > > > > Ok, this looks better, let me see how well the build breaks with some of > > > these changes > > > > I believe I can rewrite my patch like this and then it will be much nicer since > > we may constify all the rest without calling __dev_fwnode_const() directly. > > > > Are you agree? > > Yes, I think this is a much better option, try it and see. Below is the > patch I'm running through my build systems at the moment, feel free to > copy the style for your change as well. Yep, thanks for sharing! -- With Best Regards, Andy Shevchenko