Re: [PATCH 0/10] More Rust bindings for device property reads

Andrew Ballance
2025-03-26T20:57:55Z

Hi thanks for sending these in.

On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote:
> This is my first time posting to the mailing list, please let me know if
> I did anything wrong.

you probably will have to resubmit in the patch canonical format[1]

I would recomend reading the docs but in summary:
- all of your patches should have the subsystem in the subject line.
- patch 6 is missing a commit message
- commit messages should be written in the imperitive tone
- a couple of your commit messages give a reason for the changes but
do not have a summary of the changes
- for your v2 you should add a diffstat to your cover letter running
`git format-patch --base=auto --cover-letter` does this automatically
for you

Andrew

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format