Re: [PATCH 01/10] rust: Move property_present to property.rs

Rob Herring
2025-03-26T22:41:33Z

On Wed, Mar 26, 2025 at 03:51:06PM -0500, Rob Herring wrote:
> On Wed, Mar 26, 2025 at 06:13:40PM +0100, Remo Senekowitsch wrote:
> > Not all property-related APIs can be exposed directly on a device.
> > For example, iterating over child nodes of a device will yield
> > fwnode_handle. Thus, in order to access properties on these child nodes,
> > the APIs has to be duplicated on a fwnode as they are in C.
>
> s/has/have/
>
> >
> > A related discussion can be found on the R4L Zulip[1].
> >
> > [1] https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/DS90UB954.20driver.20done.2C.20ready.20to.20upstream.3F/near/505415697
>
> Useful below the '---', but I don't think we want to keep this link
> forever. And who knows how long it will be valid? The commit msg needs
> to stand on its own, and I think it does.
>
> >
> > Signed-off-by: Remo Senekowitsch <remo@buenzli.dev>
> > ---
> > rust/helpers/helpers.c | 1 +
> > rust/helpers/property.c | 13 ++++++++
> > rust/kernel/device.rs | 7 ----
> > rust/kernel/lib.rs | 1 +
> > rust/kernel/property.rs | 73 +++++++++++++++++++++++++++++++++++++++++
> > 5 files changed, 88 insertions(+), 7 deletions(-)
> > create mode 100644 rust/helpers/property.c
> > create mode 100644 rust/kernel/property.rs

Also, property.rs needs to be added to MAINTAINERS. I guess it goes
under driver core with Greg.

Rob