Re: [PATCH 0/10] More Rust bindings for device property reads

Andy Shevchenko
2025-03-27T08:42:33Z

On Wed, Mar 26, 2025 at 03:54:09PM -0500, Andrew Ballance wrote:
> Hi thanks for sending these in.
>
> On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote:
> > This is my first time posting to the mailing list, please let me know if
> > I did anything wrong.
>
> you probably will have to resubmit in the patch canonical format[1]
>
> I would recomend reading the docs but in summary:
> - all of your patches should have the subsystem in the subject line.
> - patch 6 is missing a commit message
> - commit messages should be written in the imperitive tone
> - a couple of your commit messages give a reason for the changes but
> do not have a summary of the changes

> - for your v2 you should add a diffstat to your cover letter running
> `git format-patch --base=auto --cover-letter` does this automatically
> for you

Also -v<X> gives the proper versioning.

> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

--
With Best Regards,
Andy Shevchenko