From: Chen Yu <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>
Cc: <linux-acpi@vger.kernel.org>,
<acpica-devel@lists.linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
Hariganesh Govindarajulu <hariganesh.govindarajulu@intel.com>
Subject: Re: [PATCH v2] ACPI: tools: pfrut: Check if the input of level and type is in the right numeric range
Date: Wed, 8 Mar 2023 13:15:43 +0800 [thread overview]
Message-ID: <ZAgZ/xlXl59WQLul@chenyu5-mobl1> (raw)
In-Reply-To: <20230308130902.18397-1-yu.c.chen@intel.com>
On 2023-03-08 at 21:09:02 +0800, Chen Yu wrote:
> The user provides arbitrary non-numeic value to level and type, which could
> bring expected bahavior. In this case the expected behavior would be to throw
> an error.
>
> pfrut -h
> usage: pfrut [OPTIONS]
> code injection:
> -l, --load
> -s, --stage
> -a, --activate
> -u, --update [stage and activate]
> -q, --query
> -d, --revid
> update telemetry:
> -G, --getloginfo
> -T, --type(0:execution, 1:history)
> -L, --level(0, 1, 2, 4)
> -R, --read
> -D, --revid log
>
> pfrut -T A
> pfrut -G
> log_level:0
> log_type:0
> log_revid:2
> max_data_size:65536
> chunk1_size:0
> chunk2_size:1530
> rollover_cnt:0
> reset_cnt:17
>
> Fix this by restricting the input to be in the expected range.
>
> Reported-by: Hariganesh Govindarajulu <hariganesh.govindarajulu@intel.com>
> Suggested-by: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
>
Please ignore this version due to broken format, I'll send a new one.
Sorry for the noise.
thanks,
Chenyu
next prev parent reply other threads:[~2023-03-08 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 13:09 [PATCH v2] ACPI: tools: pfrut: Check if the input of level and type is in the right numeric range Chen Yu
2023-03-08 5:15 ` Chen Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-08 13:23 Chen Yu
2023-03-14 19:39 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAgZ/xlXl59WQLul@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=hariganesh.govindarajulu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox