public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Niyas Sait <niyas.sait@linaro.org>
Cc: mika.westerberg@linux.intel.com, vkoul@kernel.org,
	dmaengine@vger.kernel.org, linux-acpi@vger.kernel.org,
	Sudeep.Holla@arm.com, Souvik.Chakravarty@arm.com,
	Sunny.Wang@arm.com, lorenzo.pieralisi@linaro.org,
	bob.zhang@cixtech.com, fugang.duan@cixtech.com
Subject: Re: [RFC v1 1/1] Refactor ACPI DMA to support platforms without shared info descriptor in CSRT
Date: Wed, 22 Mar 2023 16:32:52 +0200	[thread overview]
Message-ID: <ZBsRlJ0o9Amf402f@smile.fi.intel.com> (raw)
In-Reply-To: <7ecf4fbf-392e-7c55-b731-2d61f962ddeb@linaro.org>

On Wed, Mar 22, 2023 at 12:00:36PM +0000, Niyas Sait wrote:
> On 22/03/2023 09:34, Andy Shevchenko wrote:

...

> > > > Btw, what is the real argument of not using this table?
> > > > 
> > > > Yes, I know that this is an MS extension, but why ARM needs something else and
> > > > why even that is needed at all? CSRT is only for the_shared_  DMA resources
> > > > and I think most of the IPs nowadays are using private DMA engines (or
> > > > semi-private when driver based on ID can know which channel services which
> > > > device).
> > > The issue is that shared info descriptor is not part of CSRT definition [1]
> > > and I think it is not standardized or documented anywhere.
> > > 
> > > I was specifically looking at NXP I.MX8MP platform and the DMA lines for
> > > devices are specified using FixedDMA resource descriptor. I think other Arm
> > > platforms like RPi have similar requirement.
> > Perhaps, but my question is_why_  is it so?
> > I.o.w. what is the technical background for this solution.
> > 
> 
> NXP I.MX8MP board uses shared DMA controller and the current ACPI firmware
> describes DMA request lines for devices using ACPI FixedDMA descriptors.
> 
> > JFYI: ARM platform(s) use SPCR, which is also not a part of the specification.
> 
> SPCR and CSRT tables have permissive licensing and probably okay to use
> them.
> 
> The main issue is that the shared info descriptor in the CSRT table is not a
> standard and none of the arm platforms uses them.

SPCR is not standard either. So, that's to show that this is not an argument.

Are those firmwares already in the wild? Why they can't be fixed and why
existing CSRT shared info data structure can't be used.

> >> [1]https://uefi.org/sites/default/files/resources/CSRT%20v2.pdf

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-03-22 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 16:02 [RFC v1 1/1] Refactor ACPI DMA to support platforms without shared info descriptor in CSRT Niyas Sait
2023-03-21 17:53 ` Andy Shevchenko
2023-03-21 17:56   ` Andy Shevchenko
2023-03-22  7:56   ` Niyas Sait
2023-03-22  9:34     ` Andy Shevchenko
2023-03-22  9:38       ` Andy Shevchenko
2023-03-22 12:00       ` Niyas Sait
2023-03-22 14:32         ` Andy Shevchenko [this message]
2023-03-22 15:51           ` Niyas Sait

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBsRlJ0o9Amf402f@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Souvik.Chakravarty@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=Sunny.Wang@arm.com \
    --cc=bob.zhang@cixtech.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lorenzo.pieralisi@linaro.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=niyas.sait@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox