From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 2/2] ACPI: SPCR: Amend indentation
Date: Thu, 23 Mar 2023 14:24:43 +0200 [thread overview]
Message-ID: <ZBxFC6prEE5p4Wu1@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0imGNb8pETxdJmjJ9cSJQedeb=w2dcG6huDB=SpL-ufqA@mail.gmail.com>
On Wed, Mar 22, 2023 at 07:50:55PM +0100, Rafael J. Wysocki wrote:
> On Wed, Mar 22, 2023 at 11:26 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > 2) Remove double spaces for consistency.
>
> I don't quite agree with this.
>
> Double spaces after a period are recognized as end-of-sentence markers
> by some editors (notably vi), so if they have been used intentionally,
> I see no reason to replace them.
For the sake of consistency. There places in very same file which do not
follow this. I can invert and add a space to the rest. Do you prefer that?
The reasoning will be kept the same, though.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-23 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:22 [PATCH v1 1/2] ACPI: SPCR: Prefix error messages with FW_BUG Andy Shevchenko
2023-03-22 10:22 ` [PATCH v1 2/2] ACPI: SPCR: Amend indentation Andy Shevchenko
2023-03-22 18:50 ` Rafael J. Wysocki
2023-03-23 12:24 ` Andy Shevchenko [this message]
2023-03-23 20:31 ` Rafael J. Wysocki
2023-03-24 9:05 ` Andy Shevchenko
2023-03-24 11:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBxFC6prEE5p4Wu1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox