From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
Len Brown <lenb@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Michael Brunner <michael.brunner@kontron.com>
Subject: Re: [PATCH v2 1/2] ACPI: platform: Ignore SMB0001 only when it has resources
Date: Mon, 26 Jun 2023 13:44:34 +0300 [thread overview]
Message-ID: <ZJlsEggaJZc9u15T@smile.fi.intel.com> (raw)
In-Reply-To: <ZJlJFtsXoC6JyLxY@smile.fi.intel.com>
On Mon, Jun 26, 2023 at 11:15:19AM +0300, Andy Shevchenko wrote:
> On Fri, Jun 23, 2023 at 04:43:55PM +0200, Rafael J. Wysocki wrote:
> > On Thu, Jun 22, 2023 at 8:19 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, Jun 22, 2023 at 05:53:13PM +0200, Rafael J. Wysocki wrote:
> > > > On Wed, Jun 21, 2023 at 5:16 PM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > BTW, this doesn't need to increment the count even. It could just
> > terminate the walk on the first valid resource found and tell the
> > caller to return true in that case.
>
> Indeed, thank you for the hint!
Actually it's doesn't matter if we count them or not, we still must use the
context of the call to set up a flag or whatever. With the current code in mind
I prefer to count resources and compare that to be non-zero. This will help to
read and understand code better.
That said, I will go with (*counter)++;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-26 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:16 [PATCH v2 1/2] ACPI: platform: Ignore SMB0001 only when it has resources Andy Shevchenko
2023-06-21 15:16 ` [PATCH v2 2/2] ACPI: platform: Move SMB0001 HID to the header and reuse Andy Shevchenko
2023-06-23 5:54 ` Wolfram Sang
2023-06-22 15:53 ` [PATCH v2 1/2] ACPI: platform: Ignore SMB0001 only when it has resources Rafael J. Wysocki
2023-06-22 18:18 ` Andy Shevchenko
2023-06-23 14:43 ` Rafael J. Wysocki
2023-06-26 8:15 ` Andy Shevchenko
2023-06-26 10:44 ` Andy Shevchenko [this message]
2023-06-26 12:11 ` Rafael J. Wysocki
2023-06-26 13:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJlsEggaJZc9u15T@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andi.shyti@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.brunner@kontron.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox