From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99CC3C0015E for ; Fri, 21 Jul 2023 10:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229836AbjGUKsn (ORCPT ); Fri, 21 Jul 2023 06:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbjGUKsj (ORCPT ); Fri, 21 Jul 2023 06:48:39 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE731710 for ; Fri, 21 Jul 2023 03:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689936518; x=1721472518; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PPKQcDVhLLTeC60IQNJOoLbReyavUTfuP4zZdRc3Nzo=; b=DeOgxzfsuzqTSYeppkqo8f+k4L/sbhohAnONKsARHIMoMJqgw+7PZ2/f tNUxYA8nMVwQoCmjxrl+ftFf8dawMqpICL/yW1yf+2rRdlHsRkBrhLmE9 Ydq4ZbLCw0FQ+Kc86NIvjgg61V+zkNZQrc/ybadFdZ+D+DY4u8Tyml3W4 Sz0NErq5AmhHyrjhv7yvVcOtq1kXrkGVYhpM+y++J6WmIuNKt0suEUZ9+ SQFmxDdixPfR0bI5Z2gxmzhvKkujEtcn+2B+YsV6UNKuDwpPRbk7aEJHj jGJ3akizou5VCYReg1Cjjm2WryD2pCmuZx/dv1kErwUeb3T+vsXgBOlGw Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="370595468" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="370595468" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 03:48:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="759913744" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="759913744" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2023 03:48:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMngY-000kCa-2O; Fri, 21 Jul 2023 13:48:34 +0300 Date: Fri, 21 Jul 2023 13:48:34 +0300 From: Andy Shevchenko To: Cezary Rojewski Cc: rafael@kernel.org, robert.moore@intel.com, linux-acpi@vger.kernel.org, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com Subject: Re: [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt Message-ID: References: <20230721094722.300586-1-cezary.rojewski@intel.com> <20230721094722.300586-3-cezary.rojewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721094722.300586-3-cezary.rojewski@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jul 21, 2023 at 11:47:20AM +0200, Cezary Rojewski wrote: > While there is no strict limit to amount of NHLT tables present, usually > just the first one is utilized. To simplify implementation of sound > drivers, provide publicly accessible pointer. Accessing it after calling > acpi_nhlt_get_gbl_table() yields the first NHLT table met during the > scan. ... > @@ -594,6 +594,9 @@ config ACPI_PRMT > +config ACPI_NHLT Wouldn't be better to squeeze it to the most ordered piece of the file, so the list of the table support code files will be kinda ordered? Otherwise looks good to me, FWIW, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko