public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: rafael@kernel.org, robert.moore@intel.com,
	linux-acpi@vger.kernel.org, amadeuszx.slawinski@linux.intel.com,
	pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt
Date: Fri, 21 Jul 2023 16:52:33 +0300	[thread overview]
Message-ID: <ZLqNoURJVG47xtjy@smile.fi.intel.com> (raw)
In-Reply-To: <668566f3-c545-f10a-f2bd-37419f60b91c@intel.com>

On Fri, Jul 21, 2023 at 03:18:11PM +0200, Cezary Rojewski wrote:
> On 2023-07-21 2:55 PM, Andy Shevchenko wrote:
> > On Fri, Jul 21, 2023 at 02:44:42PM +0200, Cezary Rojewski wrote:
> > > On 2023-07-21 12:48 PM, Andy Shevchenko wrote:
> > > > On Fri, Jul 21, 2023 at 11:47:20AM +0200, Cezary Rojewski wrote:

...

> > > > > @@ -594,6 +594,9 @@ config ACPI_PRMT
> > > > 
> > > > > +config ACPI_NHLT
> > > > 
> > > > Wouldn't be better to squeeze it to the most ordered piece of the file, so
> > > > the list of the table support code files will be kinda ordered?
> > > 
> > > I may be wrong about this, but it seems that the driver/acpi/Kconfig file
> > > does not list tables supported in any kind of ordered fashion. I'd refrain
> > > from reordering the Kconfig in this very patch and rather have such job done
> > > in a separate series instead.
> > 
> > Yes, but my point to make this job easier to whoever will do it.
> 
> Hmm.. I see that the most occurrences of word "Table" is around
> ACPI_SPCR_TABLE/_FPDT/LPIT area. Should I put it after ACPI_LPIT perhaps?

Works for me!
As I wrote "most ordered place" and "kinda ordered" above.

> > > > Otherwise looks good to me, FWIW,
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-07-21 13:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  9:47 [PATCH v3 0/4] ACPI: NHLT: Access and query helpers Cezary Rojewski
2023-07-21  9:47 ` [PATCH v3 1/4] ACPI: NHLT: Device configuration access interface Cezary Rojewski
2023-07-21  9:47 ` [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt Cezary Rojewski
2023-07-21 10:48   ` Andy Shevchenko
2023-07-21 12:44     ` Cezary Rojewski
2023-07-21 12:55       ` Andy Shevchenko
2023-07-21 13:18         ` Cezary Rojewski
2023-07-21 13:52           ` Andy Shevchenko [this message]
2023-07-21  9:47 ` [PATCH v3 3/4] ACPI: NHLT: Table manipulation helpers Cezary Rojewski
2023-07-21  9:47 ` [PATCH v3 4/4] ACPI: NHLT: Add query functions Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLqNoURJVG47xtjy@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox