From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104F7C41513 for ; Fri, 4 Aug 2023 16:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231282AbjHDQ4j (ORCPT ); Fri, 4 Aug 2023 12:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbjHDQ4i (ORCPT ); Fri, 4 Aug 2023 12:56:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4A31994; Fri, 4 Aug 2023 09:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691168197; x=1722704197; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gpDidnsvALbETLwYUDIaqkBOrRmLDkWhHtFiUIEPsrc=; b=nVAj6Ki+r/HOcAoZl0tVkX9yVOmFL5BwoY+SdflYbP2ebK9ZRyGrXPZh RfbKMEZq/ugTq+c0ZNTRmaUxXtqX1UKQEUdcV32RgNgC8Yf83AaP1GL8j AysF0YJXaxTD5IL+bLG+cv8YSXOXz5z9QDKTJgCUV6zae6V3fbDEeD8n3 AUsrfCG9K5ziIqYePqtB8fiCLqul/dBUPxiEWasTqcdDcoGayXVm4T/Zn rJtUHHEfX+ZlWR783UV+MoDwcAnWo+7yXzJfxjQCe9wgL1rQRNQy7h37P zZBDRqk+nspXIDyCzN7ndZh+OlYrRaqRasaUysLRwsyzVPHG5IUnkbjCD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="401156666" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="401156666" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 09:56:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="723705867" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="723705867" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 04 Aug 2023 09:56:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRy6E-00HEmR-1a; Fri, 04 Aug 2023 19:56:26 +0300 Date: Fri, 4 Aug 2023 19:56:26 +0300 From: Andy Shevchenko To: Conor Dooley Cc: Sunil V L , linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Anup Patel , Marc Zyngier , Bjorn Helgaas , Robert Moore , Haibo Xu , Andrew Jones , Conor Dooley , Atish Kumar Patra Subject: Re: [RFC PATCH v1 09/21] RISC-V: cacheflush: Initialize CBO variables on ACPI systems Message-ID: References: <20230803175916.3174453-1-sunilvl@ventanamicro.com> <20230803175916.3174453-10-sunilvl@ventanamicro.com> <20230804-dreamy-unharmed-a502d02af35a@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Aug 04, 2023 at 07:52:56PM +0300, Andy Shevchenko wrote: > On Fri, Aug 04, 2023 at 04:19:27PM +0100, Conor Dooley wrote: > > On Fri, Aug 04, 2023 at 05:59:51PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 04, 2023 at 02:50:34PM +0530, Sunil V L wrote: > > > > On Fri, Aug 04, 2023 at 08:56:29AM +0300, Andy Shevchenko wrote: > > > > > On Thu, Aug 03, 2023 at 11:29:04PM +0530, Sunil V L wrote: ... > > > > > > +#include > > > > > > > > > > What do you need this for? > > > > > > > > > > > #include > > > > > > > > > When CONFIG_ACPI is disabled, this include is required to get > > > > acpi_get_cbo_block_size(). > > > > > > How is it useful without ACPI being enabled? > > > > It is not, as evidenced by the `return -EINVAL;`. > > > > > If it's indeed > > > (in which I do not believe), better to make sure you have it > > > avaiable independently on CONFIG_ACPI. Otherwise, just put > > > #ifdef CONFIG_ACPI around the call. > > > > Let's not litter the code with ifdeffery please where it can be easily > > avoided. > > Including asm/acpi.h looks to me as a "let's avoid it with a hack that it > is uglier than ifdeffery". Sorry, but ifdeffery for ACPI, with all my full > agreement with the statement that it's not good, is the correct way to fix > this. On the other hand this is an arch code and I see precedents of using the headers together, alas, it seems not better to me that ugly ifdeffery. So, I leave it to the respective maintainers to decide. -- With Best Regards, Andy Shevchenko