public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Guanghui Feng <guanghuifeng@linux.alibaba.com>,
	guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com,
	alikernel-developer@linux.alibaba.com, will@kernel.org
Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info()
Date: Thu, 27 Jul 2023 14:59:02 +0100	[thread overview]
Message-ID: <ZMJ4JnlVlqkO3E0P@arm.com> (raw)
In-Reply-To: <ZMJzj2oe0B2Qp8vp@lpieralisi>

On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote:
> On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote:
> > According to the ARM IORT specifications DEN 0049 issue E,
> > the "Number of IDs" field in the ID mapping format reports
> > the number of IDs in the mapping range minus one.
> > 
> > In iort_node_get_rmr_info(), we erroneously skip ID mappings
> > whose "Number of IDs" equal to 0, resulting in valid mapping
> > nodes with a single ID to map being skipped, which is wrong.
> > 
> > Fix iort_node_get_rmr_info() by removing the bogus id_count
> > check.
> > 
> > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions")
> > Signed-off-by: Guanghui Feng <guanghuifeng@linux.alibaba.com>
> > ---
> >  drivers/acpi/arm64/iort.c | 3 ---
> >  1 file changed, 3 deletions(-)
> 
> Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> 
> Catalin/Will,
> 
> can you pick this up please ?

Would you like it merged in 6.5 or 6.6 is fine?

Thanks.

-- 
Catalin

  reply	other threads:[~2023-07-27 13:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 11:33 [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Guanghui Feng
2023-07-18  7:52 ` Lorenzo Pieralisi
2023-07-18  8:54   ` guanghui.fgh
2023-07-18  9:16     ` Lorenzo Pieralisi
2023-07-18  8:56   ` Shameerali Kolothum Thodi
2023-07-19  9:13     ` Hanjun Guo
2023-07-26  9:07       ` Hanjun Guo
2023-07-27 13:39 ` Lorenzo Pieralisi
2023-07-27 13:59   ` Catalin Marinas [this message]
2023-07-27 14:17     ` Lorenzo Pieralisi
2023-07-27 15:00       ` Will Deacon
2023-07-27 15:08         ` Lorenzo Pieralisi
2023-07-28 12:05           ` Catalin Marinas
2023-07-28 13:55 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMJ4JnlVlqkO3E0P@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=alikernel-developer@linux.alibaba.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=guanghuifeng@linux.alibaba.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox