From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8DBC0015E for ; Thu, 27 Jul 2023 13:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbjG0N7J (ORCPT ); Thu, 27 Jul 2023 09:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232010AbjG0N7J (ORCPT ); Thu, 27 Jul 2023 09:59:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ACABE4D; Thu, 27 Jul 2023 06:59:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB87761E92; Thu, 27 Jul 2023 13:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 699AAC433C8; Thu, 27 Jul 2023 13:59:05 +0000 (UTC) Date: Thu, 27 Jul 2023 14:59:02 +0100 From: Catalin Marinas To: Lorenzo Pieralisi Cc: Guanghui Feng , guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com, will@kernel.org Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Message-ID: References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote: > On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > > According to the ARM IORT specifications DEN 0049 issue E, > > the "Number of IDs" field in the ID mapping format reports > > the number of IDs in the mapping range minus one. > > > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > > whose "Number of IDs" equal to 0, resulting in valid mapping > > nodes with a single ID to map being skipped, which is wrong. > > > > Fix iort_node_get_rmr_info() by removing the bogus id_count > > check. > > > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") > > Signed-off-by: Guanghui Feng > > --- > > drivers/acpi/arm64/iort.c | 3 --- > > 1 file changed, 3 deletions(-) > > Acked-by: Lorenzo Pieralisi > > Catalin/Will, > > can you pick this up please ? Would you like it merged in 6.5 or 6.6 is fine? Thanks. -- Catalin