From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EED0C001DE for ; Fri, 28 Jul 2023 12:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233770AbjG1MGA (ORCPT ); Fri, 28 Jul 2023 08:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234096AbjG1MFq (ORCPT ); Fri, 28 Jul 2023 08:05:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D3D3C29; Fri, 28 Jul 2023 05:05:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CAAD462127; Fri, 28 Jul 2023 12:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B531DC433C7; Fri, 28 Jul 2023 12:05:36 +0000 (UTC) Date: Fri, 28 Jul 2023 13:05:33 +0100 From: Catalin Marinas To: Lorenzo Pieralisi Cc: Will Deacon , Guanghui Feng , guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Message-ID: References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> <20230727150042.GC19940@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jul 27, 2023 at 05:08:20PM +0200, Lorenzo Pieralisi wrote: > On Thu, Jul 27, 2023 at 04:00:43PM +0100, Will Deacon wrote: > > On Thu, Jul 27, 2023 at 04:17:49PM +0200, Lorenzo Pieralisi wrote: > > > On Thu, Jul 27, 2023 at 02:59:02PM +0100, Catalin Marinas wrote: > > > > On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote: > > > > > On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > > > > > > According to the ARM IORT specifications DEN 0049 issue E, > > > > > > the "Number of IDs" field in the ID mapping format reports > > > > > > the number of IDs in the mapping range minus one. > > > > > > > > > > > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > > > > > > whose "Number of IDs" equal to 0, resulting in valid mapping > > > > > > nodes with a single ID to map being skipped, which is wrong. > > > > > > > > > > > > Fix iort_node_get_rmr_info() by removing the bogus id_count > > > > > > check. > > > > > > > > > > > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") > > > > > > Signed-off-by: Guanghui Feng > > > > > > --- > > > > > > drivers/acpi/arm64/iort.c | 3 --- > > > > > > 1 file changed, 3 deletions(-) > > > > > > > > > > Acked-by: Lorenzo Pieralisi > > > > > > > > > > Catalin/Will, > > > > > > > > > > can you pick this up please ? > > > > > > > > Would you like it merged in 6.5 or 6.6 is fine? > > > > > > It is definitely a fix - I don't think that's super urgent > > > though, bug has been there since v6.0 so the fix can probably > > > wait to trickle back from v6.6. > > > > On the flip side, it's a fix, Hanjun has tested it and we have a few > > weeks in case we need to revert it. > > > > So I'd be inclined to say Catalin should pick it up for 6.5, unless > > there's a good reason to wait? > > No reason to wait - I just wanted to make clear it is not urgent, > if it is possible it makes sense for it to get into v6.5. Happy to pick it up. -- Catalin