Re: [PATCH v2] platform/chrome: chromeos_acpi: support official HID GOOG0016

Guenter Roeck
2023-07-28T15:04:07Z

On Thu, Jul 27, 2023 at 11:55 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> Support official HID GOOG0016 for ChromeOS ACPI (see [1]).
>
> [1]: https://crrev.com/c/2266713
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> ---
> Changes from v1[2]:
> - Preserve the PNP ID GGL0001 for backward compatible to older firmwares.
> - Modify commit title and message accordingly.
>
> [2]: https://patchwork.kernel.org/project/chrome-platform/patch/20230728014256.3836298-1-tzungbi@kernel.org/
>
> .../ABI/testing/sysfs-driver-chromeos-acpi | 30 +++++++++----------
> .../acpi/chromeos-acpi-device.rst | 5 ++--
> drivers/platform/chrome/chromeos_acpi.c | 2 +-
> 3 files changed, 18 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> index c308926e1568..8e8a5d6610b8 100644
> --- a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> +++ b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> @@ -1,4 +1,4 @@
> -What: /sys/bus/platform/devices/GGL0001:*/BINF.2
> +What: /sys/bus/platform/devices/GOOG0016:*/BINF.2

Doesn't the description mean that both sysfs directories might be seen
in the field ?
If so, replacing one with the other would be wrong.

Thanks,
Guenter