From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9D6C41513 for ; Wed, 2 Aug 2023 14:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbjHBOq1 (ORCPT ); Wed, 2 Aug 2023 10:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231688AbjHBOq0 (ORCPT ); Wed, 2 Aug 2023 10:46:26 -0400 Received: from mgamail.intel.com (unknown [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAEAD1FCB; Wed, 2 Aug 2023 07:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690987585; x=1722523585; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Bx06kqb1Xm2I20w1+rZ1+epKaG7EZjZ1yMRMm6Jp5Ck=; b=b4pEH5g6k4PdLOmSb6CWzjGV7gNLCdEzTsmpuCzQjJd38k4vCzvHZD3a zBfWvmiUYssakdvuIFtAcaScIM+W/4iTw9CeoiHuaL7TcaPVNkCqe9eHC SngyaZ82JsCAgoiUJLSy2CkUPmeu8jqZz1KQaAZs3B+pKRHYQrRQeg4gt NaC/GK2cTr2VoqWaOIKlr3TxpY5vJTCc8KtRq1yr08TTAYTN4ziRmR2px HO6QuvDKpU74ouE6Sax92cMQkF2oZx0UDuiNCnxNs0zvM/ZQ0/CpcriSa tK389P4tMnTgL+XaTHa32NZkj/TywkBJ7ypYoNlArC8BEe6qQ33Ru4qzJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="368507766" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="368507766" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 07:46:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="1059861757" X-IronPort-AV: E=Sophos;i="6.01,249,1684825200"; d="scan'208";a="1059861757" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 02 Aug 2023 07:46:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRD7E-0037id-2G; Wed, 02 Aug 2023 17:46:20 +0300 Date: Wed, 2 Aug 2023 17:46:20 +0300 From: Andy Shevchenko To: Biju Das Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , Dmitry Torokhov , Wolfram Sang , Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v3 1/2] drivers: fwnode: Extend device_get_match_data() to struct bus_type Message-ID: References: <20230801170318.82682-1-biju.das.jz@bp.renesas.com> <20230801170318.82682-2-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Aug 02, 2023 at 06:32:18AM +0000, Biju Das wrote: > > On Tue, Aug 01, 2023 at 06:03:17PM +0100, Biju Das wrote: ... > > * > > * Besides the fact that some drivers abuse the device ID driver_data > > type > > * and claim it to be integer, for the bus specific ID tables the > > driver_data > > * may be defined as kernel_ulong_t. For these tables 0 is a valid > > response, > > * but not for this function. It's recommended to covert those either to > > Will fix the typo covert->convert Thank you! > > avoid > > * 0 or use a real pointer to the predefined driver data. -- With Best Regards, Andy Shevchenko