Re: [PATCH v4 1/4] ACPI: NHLT: Device configuration access interface

[andy.shevchenko@gmail.com]

Fri, Jul 21, 2023 at 05:48:10PM +0200, Cezary Rojewski kirjoitti:
> Device configuration structures are plenty so declare a struct for each
> known variant. As neither of them shall be accessed without verifying
> the memory block first, introduce macros to make it easy to do so.
> 
> Link: https://github.com/acpica/acpica/pull/881

Thinking of this over night (as I replied in the above)...

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Sorry, but seems I have to retract my tag and even more, NAK to the ACPICA changes.

I have thought that this is something new to the header there, but it appears that
it duplicates (in a wrong way in my opinion) existing data types.

Existing data types are crafted (as far as I get them) in a way to be able to be
combined in the union. In the similar way how _CRS is parsed in DSDT (first that
comes to my mind). Hence that "simplification" is quite wrong in a few ways:
- it breaks ACPICA agreement on naming schema
- it duplicates existing data
- it made it even partially
- it is fine and correct in ACPICA to have long dereferenced data, again see
  for the union of acpi_object

I trully believe now that the above change in ACPICA must be reverted.

Again, sorry for this late bad news from my side. I have no clue why
it was merged, perhaps lack of review? Or anything subtle I so miserably
missed?

-- 
With Best Regards,
Andy Shevchenko