From: "Jörn Engel" <joern@purestorage.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Uday Shankar <ushankar@purestorage.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Borislav Petkov <bp@alien8.de>, Len Brown <len.brown@intel.com>,
linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Subject: Re: [PATCH] Revert "ACPI, APEI, use raw spinlock in ERST"
Date: Tue, 22 Aug 2023 19:57:52 -0700 [thread overview]
Message-ID: <ZOV1sM8xZ6+P48Z1@cork> (raw)
In-Reply-To: <87cyzebi00.fsf@yhuang6-desk2.ccr.corp.intel.com>
On Wed, Aug 23, 2023 at 10:38:23AM +0800, Huang, Ying wrote:
>
> Thanks for reminding! That's a good point.
>
> Checked the implementation of rt_mutex version of spin_trylock(). One
> possible code path is,
>
> spin_trylock()
> rt_spin_trylock()
> __rt_spin_trylock()
> rt_mutex_slowtrylock()
> raw_spin_lock_irqsave()
You are right. I'm actually quite surprised how we turn a trylock into
a spinning lock. Now I know, thank you!
Jörn
--
"Security vulnerabilities are here to stay."
-- Scott Culp, Manager of the Microsoft Security Response Center, 2001
next prev parent reply other threads:[~2023-08-23 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 1:09 [PATCH] Revert "ACPI, APEI, use raw spinlock in ERST" Uday Shankar
2023-08-22 1:56 ` Huang, Ying
2023-08-22 3:16 ` Jörn Engel
2023-08-22 23:45 ` Uday Shankar
2023-08-23 2:38 ` Huang, Ying
2023-08-23 2:57 ` Jörn Engel [this message]
2023-08-23 21:09 ` Jörn Engel
2023-08-23 2:28 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOV1sM8xZ6+P48Z1@cork \
--to=joern@purestorage.com \
--cc=bp@alien8.de \
--cc=gpiccoli@igalia.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=ushankar@purestorage.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox