From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ken Xue <Ken.Xue@amd.com>
Cc: linux-acpi@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
rafael@kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] acpi: trigger wakeup key event from power button
Date: Mon, 11 Sep 2023 12:42:55 +0300 [thread overview]
Message-ID: <ZP7hH9i6ZQgINbcB@smile.fi.intel.com> (raw)
In-Reply-To: <20230908095747.446389-1-Ken.Xue@amd.com>
On Fri, Sep 08, 2023 at 05:57:49PM +0800, Ken Xue wrote:
> Andorid can wakeup from various wakeup sources,
> but only several wakeup sources can wake up screen
> with right events(POWER, WAKEUP) from input device.
>
> Regarding pressing acpi power button, it can resume system and
> ACPI_BITMASK_WAKE_STATUS and ACPI_BITMASK_POWER_BUTTON_STATUS
> are set in pm1a_sts, but kernel does not report any key
> event to user space during resume by default.
>
> So, trigger wakeup key event to user space during resume
> from power button.
> Reported-by: kernel test robot <lkp@intel.com>
Are you sure?
> Closes: https://lore.kernel.org/oe-kbuild-all/202309080315.txQUEyHQ-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202309080239.IiC7uLpW-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202309080351.xHt2qhP2-lkp@intel.com/
Are you sure?
>
>
Blank lines are not allowed in the tag block.
> Signed-off-by: Ken Xue <Ken.Xue@amd.com>
> ---
How this change is different to the previous patch you sent?
Do you forgot versioning?
Do you forgot changelog?
Please, read Submitting Patches documentation before trying again.
It will help to make your contribution nice and understandable.
...
> + if (button->type == ACPI_BUTTON_TYPE_POWER) {
if (... != )
return;
?
> + input = button->input;
> + input_report_key(input, KEY_WAKEUP, 1);
> + input_sync(input);
> + input_report_key(input, KEY_WAKEUP, 0);
> + input_sync(input);
> + }
...
> +#include <linux/acpi.h>
There is no users of this header.
Check how forward declaration can be used (as it's done in many other headers).
> +extern void acpi_power_button_wakeup(struct acpi_device *device);
...
> +static inline void acpi_power_button_wakeup(struct acpi_device *device)
> +{
> +}
This can be done on a single line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-11 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 9:57 [PATCH] acpi: trigger wakeup key event from power button Ken Xue
2023-09-11 9:42 ` Andy Shevchenko [this message]
2023-09-12 5:32 ` Ken Xue
2023-09-12 9:30 ` Andy Shevchenko
2023-09-12 12:53 ` Ken Xue
-- strict thread matches above, loose matches on Subject: below --
2023-09-07 7:43 Ken Xue
2023-09-07 18:51 ` kernel test robot
2023-09-07 19:34 ` kernel test robot
2023-09-07 20:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP7hH9i6ZQgINbcB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ken.Xue@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox