From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs
Date: Mon, 11 Sep 2023 18:36:32 +0300 [thread overview]
Message-ID: <ZP80AKHkUyFP7B06@smile.fi.intel.com> (raw)
In-Reply-To: <22698b72-b293-9ad8-908f-f6aee85430d7@redhat.com>
On Mon, Sep 11, 2023 at 04:12:00PM +0200, Hans de Goede wrote:
> On 9/11/23 16:04, Bartosz Golaszewski wrote:
...
> >>>>>>>> + lookup->dev_id = KBUILD_MODNAME;
> >>>>>>>> + lookup->table[0].key = chip;
> >>>>>>>> + lookup->table[0].chip_hwnum = pin;
> >>>>>>>> + lookup->table[0].con_id = con_id;
> >>>>>>>> + lookup->table[0].flags = active_low ? GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH;
Actually you can use GPIO_LOOKUP() macro here as it provides a compound
literal.
lookup->table[0] = GPIO_LOOKUP(...);
> Therefor I don't want to / cannot change the hashes of the commits,
> so a follow-up patch it is.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-11 21:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 14:18 [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-09 14:18 ` [PATCH 1/8] gpiolib: acpi: Check if a GPIO is listed in ignore_interrupt earlier Hans de Goede
2023-09-10 7:51 ` Andy Shevchenko
2023-09-11 5:24 ` Mika Westerberg
2023-09-11 9:50 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 2/8] gpiolib: acpi: Add a ignore interrupt quirk for Peaq C1010 Hans de Goede
2023-09-10 7:53 ` Andy Shevchenko
2023-09-11 5:24 ` Mika Westerberg
2023-09-11 9:51 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 3/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip from " Hans de Goede
2023-09-11 9:52 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 4/8] platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip support Hans de Goede
2023-09-10 7:56 ` Andy Shevchenko
2023-09-10 7:57 ` Andy Shevchenko
2023-09-09 14:18 ` [PATCH 5/8] platform/x86: x86-android-tablets: Create a platform_device from module_init() Hans de Goede
2023-09-10 8:07 ` Andy Shevchenko
2023-09-10 11:19 ` Hans de Goede
2023-09-09 14:18 ` [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs Hans de Goede
2023-09-10 8:24 ` Andy Shevchenko
2023-09-10 11:26 ` Hans de Goede
2023-09-11 12:49 ` Bartosz Golaszewski
2023-09-11 12:56 ` Andy Shevchenko
2023-09-11 12:59 ` Hans de Goede
2023-09-11 12:59 ` Bartosz Golaszewski
2023-09-10 11:28 ` Hans de Goede
2023-09-11 12:50 ` Bartosz Golaszewski
2023-09-11 13:07 ` Hans de Goede
2023-09-11 13:18 ` Bartosz Golaszewski
2023-09-11 13:32 ` Hans de Goede
2023-09-11 13:37 ` Bartosz Golaszewski
2023-09-11 13:53 ` Hans de Goede
2023-09-11 14:04 ` Bartosz Golaszewski
2023-09-11 14:12 ` Hans de Goede
2023-09-11 15:36 ` Andy Shevchenko [this message]
2023-09-11 16:03 ` Bartosz Golaszewski
2023-09-09 14:18 ` [PATCH 7/8] platform/x86: x86-android-tablets: Use platform-device as gpio-keys parent Hans de Goede
2023-09-09 14:18 ` [PATCH 8/8] platform/x86: x86-android-tablets: Drop "linux,power-supply-name" from lenovo_yt3_bq25892_0_props[] Hans de Goede
2023-09-11 8:18 ` [PATCH 0/8] x86-android-tablets: Stop using gpiolib private APIs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP80AKHkUyFP7B06@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox