From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9EACA0EC3 for ; Mon, 11 Sep 2023 21:28:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236234AbjIKVTj (ORCPT ); Mon, 11 Sep 2023 17:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242453AbjIKPgm (ORCPT ); Mon, 11 Sep 2023 11:36:42 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7515E9; Mon, 11 Sep 2023 08:36:38 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="375464093" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="375464093" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 08:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="743393633" X-IronPort-AV: E=Sophos;i="6.02,244,1688454000"; d="scan'208";a="743393633" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 08:36:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qfixl-008MjX-0U; Mon, 11 Sep 2023 18:36:33 +0300 Date: Mon, 11 Sep 2023 18:36:32 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Bartosz Golaszewski , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Mika Westerberg , Linus Walleij , platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 6/8] platform/x86: x86-android-tablets: Stop using gpiolib private APIs Message-ID: References: <20230909141816.58358-1-hdegoede@redhat.com> <20230909141816.58358-7-hdegoede@redhat.com> <0b1e0312-9144-85ed-666e-a84110b26418@redhat.com> <01a85a3d-c888-11d8-f47e-be2a26d0cb9d@redhat.com> <22698b72-b293-9ad8-908f-f6aee85430d7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22698b72-b293-9ad8-908f-f6aee85430d7@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 11, 2023 at 04:12:00PM +0200, Hans de Goede wrote: > On 9/11/23 16:04, Bartosz Golaszewski wrote: ... > >>>>>>>> + lookup->dev_id = KBUILD_MODNAME; > >>>>>>>> + lookup->table[0].key = chip; > >>>>>>>> + lookup->table[0].chip_hwnum = pin; > >>>>>>>> + lookup->table[0].con_id = con_id; > >>>>>>>> + lookup->table[0].flags = active_low ? GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH; Actually you can use GPIO_LOOKUP() macro here as it provides a compound literal. lookup->table[0] = GPIO_LOOKUP(...); > Therefor I don't want to / cannot change the hashes of the commits, > so a follow-up patch it is. -- With Best Regards, Andy Shevchenko