From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F32C71153 for ; Mon, 4 Sep 2023 10:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233758AbjIDKuZ (ORCPT ); Mon, 4 Sep 2023 06:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbjIDKuY (ORCPT ); Mon, 4 Sep 2023 06:50:24 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C99EDD; Mon, 4 Sep 2023 03:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693824621; x=1725360621; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WBXVQvn4cAjmdr8D6OmweKSu5H2pPRHiyJxB1xRH74o=; b=FnJVBIp4Gx8+F0dm3eu8cGTaZqasDgStsFNaTUJbPBRvA+m3/CAeICWv 19q5pOCxaKRZNaR6fOip48kcPCoVRWiV+3aOxIeHl7JMjZH24ZOqo9Uvp rflkpztK8mduZ3DMy5Kr3JACNR1IL4s73lHkT/rSJBCRsSMMhhXw9eMO4 bYZuzzZXryT61fDJaae+s3npO4AEKTB7eRFQGojCCX8wfxcwOOXws+c9c hzscy0garb9ADJxQ7Qi/ivjpAZNHUeYfkn+YzCpIBG8BpTCgPzDBRW5FR tIQylHBhY+ay377ToDXNHvJtVUesxhiuLo8VbSB1Hl9m8AxMgmc52TE10 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="380372456" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="380372456" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="883992451" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="883992451" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 04 Sep 2023 03:50:11 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 04 Sep 2023 13:50:15 +0300 Date: Mon, 4 Sep 2023 13:50:15 +0300 From: Heikki Krogerus To: Andy Shevchenko Cc: Saravana Kannan , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Scally , Sakari Ailus , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members Message-ID: References: <20230904104046.1682875-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230904104046.1682875-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote: > Most of the struct fwnode_handle members are for exclusive use with > device links framework. Clarify this by adding a respective comment. > > Signed-off-by: Andy Shevchenko Yes, this is important clarification. Reviewed-by: Heikki Krogerus > --- > include/linux/fwnode.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index 5700451b300f..2a72f55d26eb 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -41,6 +41,8 @@ struct device; > struct fwnode_handle { > struct fwnode_handle *secondary; > const struct fwnode_operations *ops; > + > + /* The below is used solely by device links, don't use otherwise */ > struct device *dev; > struct list_head suppliers; > struct list_head consumers; > -- > 2.40.0.1.gaa8946217a0b -- heikki