From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ken Xue <Ken.Xue@amd.com>
Cc: linux-acpi@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
rafael@kernel.org, kernel test robot <lkp@intel.com>,
cwhuang@linux.org.tw
Subject: Re: [PATCH] acpi: trigger wakeup key event from power button
Date: Tue, 12 Sep 2023 12:30:12 +0300 [thread overview]
Message-ID: <ZQAvpIKqmLeWbh0v@smile.fi.intel.com> (raw)
In-Reply-To: <2bfaa431-ca9f-c879-9967-f13d18dd4cd3@amd.com>
On Tue, Sep 12, 2023 at 01:32:02PM +0800, Ken Xue wrote:
> On 2023/9/11 17:42, Andy Shevchenko wrote:
> > On Fri, Sep 08, 2023 at 05:57:49PM +0800, Ken Xue wrote:
...
> > > Reported-by: kernel test robot <lkp@intel.com>
> > Are you sure?
>
> Thanks for review. Sorry for confusion.
> 2) test robot reported some compile warnings and errors detected by test
> robot which is fixed in V2.
Yes and that's what I'm asking about. You are not supposed to add it as the
initial problem, the patch is trying to solve, has _not_ been reported by LKP,
hasn't it?
...
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309080315.txQUEyHQ-lkp@intel.com/
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309080239.IiC7uLpW-lkp@intel.com/
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309080351.xHt2qhP2-lkp@intel.com/
> > Are you sure?
>
> Just some errors/warnings from the v1 patch.
Same as above.
...
> > > +#include <linux/acpi.h>
> > There are no users of this header.
> >
> > Check how forward declaration can be used (as it's done in many other headers).
> >
> Yes, "struct acpi_device" is defined in "include/acpi/acpi_bus.h", but
> include acpi_bus.h alone will lead to more compile issues.
>
> Regarding "forward declaration", how about
>
> typedef struct acpi_device *acpi_device;
Is it a forward declaration?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 9:57 [PATCH] acpi: trigger wakeup key event from power button Ken Xue
2023-09-11 9:42 ` Andy Shevchenko
2023-09-12 5:32 ` Ken Xue
2023-09-12 9:30 ` Andy Shevchenko [this message]
2023-09-12 12:53 ` Ken Xue
-- strict thread matches above, loose matches on Subject: below --
2023-09-07 7:43 Ken Xue
2023-09-07 18:51 ` kernel test robot
2023-09-07 19:34 ` kernel test robot
2023-09-07 20:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQAvpIKqmLeWbh0v@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ken.Xue@amd.com \
--cc=cwhuang@linux.org.tw \
--cc=linux-acpi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox