From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label()
Date: Tue, 12 Sep 2023 14:08:05 +0300 [thread overview]
Message-ID: <ZQBGlSnx3McF8m2r@smile.fi.intel.com> (raw)
In-Reply-To: <20230912100727.23197-8-brgl@bgdev.pl>
On Tue, Sep 12, 2023 at 12:07:23PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Remove all remaining uses of find_chip_by_name() (and subsequently:
> gpiochip_find()) from gpiolib.c and use the new
> gpio_device_find_by_label() instead.
...
> for (hog = &hogs[0]; hog->chip_label; hog++) {
> + struct gpio_device *gdev __free(gpio_device_put) = NULL;
In the loop?! How does it work when loop goes second iteration and so on?
> list_add_tail(&hog->list, &gpio_machine_hogs);
>
> /*
> * The chip may have been registered earlier, so check if it
> * exists and, if so, try to hog the line now.
> */
> - gc = find_chip_by_name(hog->chip_label);
> - if (gc)
> - gpiochip_machine_hog(gc, hog);
> + gdev = gpio_device_find_by_label(hog->chip_label);
> + if (gdev)
> + gpiochip_machine_hog(gpio_device_get_chip(gdev), hog);
So, do we expect the chip_label be different between hogs? Ah, seems so
as it covers _all_ hogs in the system.
> }
Even if the __free() scope works fine, I think this algorithm should be
revisited to make sure we have iterating only on hogs of the same chip.
Hence, the hogs should be placed into tree structure with a label being
the key in it.
...
> + struct gpio_device *gdev __free(gpio_device_put) = NULL;
> + gc = gpio_device_get_chip(gdev);
Similar wish here, perhaps maple tree can be utilized in the future for both of them.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 10:07 [PATCH v2 00/11] gpiolib: work towards removing gpiochip_find() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 01/11] gpiolib: make gpio_device_get() and gpio_device_put() public Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 02/11] gpiolib: add support for scope-based management to gpio_device Bartosz Golaszewski
2023-09-12 11:33 ` Andy Shevchenko
2023-09-12 11:36 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 03/11] gpiolib: provide gpio_device_find() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 04/11] gpiolib: provide gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 10:57 ` Andy Shevchenko
2023-09-14 19:55 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 05/11] gpiolib: provide gpio_device_get_desc() Bartosz Golaszewski
2023-09-12 11:00 ` Andy Shevchenko
2023-09-12 10:07 ` [PATCH v2 06/11] gpiolib: reluctantly provide gpio_device_get_chip() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 11:08 ` Andy Shevchenko [this message]
2023-09-12 11:34 ` Bartosz Golaszewski
2023-09-12 11:16 ` Andy Shevchenko
2023-09-12 11:35 ` Bartosz Golaszewski
2023-09-15 9:44 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 08/11] gpio: of: replace gpiochip_find_* with gpio_device_find_* Bartosz Golaszewski
2023-09-12 11:20 ` Andy Shevchenko
2023-09-12 10:07 ` [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find() Bartosz Golaszewski
2023-09-12 11:31 ` Andy Shevchenko
2023-09-12 10:07 ` [PATCH v2 10/11] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 11/11] gpio: sysfs: drop the mention of gpiochip_find() from sysfs code Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQBGlSnx3McF8m2r@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox