From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ken Xue <Ken.Xue@amd.com>
Cc: linux-acpi@vger.kernel.org, rafael@kernel.org, cwhuang@linux.org.tw
Subject: Re: [PATCH V4] acpi: trigger wakeup key event from power button
Date: Wed, 13 Sep 2023 14:25:17 +0300 [thread overview]
Message-ID: <ZQGcHbamHx66clr6@smile.fi.intel.com> (raw)
In-Reply-To: <20230913002145.743571-1-Ken.Xue@amd.com>
On Wed, Sep 13, 2023 at 08:21:46AM +0800, Ken Xue wrote:
> Andorid can wakeup from various wakeup sources, but only several wakeup
> sources can wake up screen with right events(POWER, WAKEUP) from input
> device.
>
> Regarding pressing acpi power button, it can resume system and
> ACPI_BITMASK_WAKE_STATUS and ACPI_BITMASK_POWER_BUTTON_STATUS are set in
> pm1a_sts, but kernel does not report any key event to user space during
> resuming by default.
>
> So, send wakeup key event to user space during resuming from power button.
LGTM from code perspective, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
assuming that maintainers will check the code from functional perspective.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-13 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 0:21 [PATCH V4] acpi: trigger wakeup key event from power button Ken Xue
2023-09-13 11:25 ` Andy Shevchenko [this message]
2023-09-14 21:58 ` kernel test robot
2023-09-15 2:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQGcHbamHx66clr6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ken.Xue@amd.com \
--cc=cwhuang@linux.org.tw \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox