From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364A32032B for ; Fri, 20 Oct 2023 18:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="B1QX3J8G" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFDA0D51; Fri, 20 Oct 2023 11:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697825517; x=1729361517; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=voEK7holIGvvAdy/wSR3LlIkMHvaF8zMe1eSBNdjLo0=; b=B1QX3J8GLxMwkTk4bzQv0Z5pGwap0f7oOlbYpBbTOO+HoQZh3Z5cw5Vk v4extxesYF00z4anLvZwERyKTVUxkfKwhQWBh9Q5TWdzfklI1SdEZwMs7 yVVYND7NSZ8WwiwbkTgh7cbPdEHDt7j/a5nQlLHDFGRRaHyfWmQBFajje mDYAsl2Kdayjo6VC1jLuGgSaujzkBqDNZiODRK6cnqrXdy8x2Ziod2pxb 6kbl7SY7c4qNs03JsGJLdvuxtRqtdI7+k12/mH4Rlk5yS6Mq9pOGprVwl sn+hU2F4hx3iUtLMRxWujr95qMS170efEmYNqZTxfIIdD5EV/FxqvXjty A==; X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="8110224" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="8110224" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 11:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="873998519" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="873998519" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 11:11:51 -0700 Date: Fri, 20 Oct 2023 21:11:48 +0300 From: Raag Jadav To: "Rafael J. Wysocki" Cc: Andy Shevchenko , len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-5-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Oct 20, 2023 at 07:11:53PM +0200, Rafael J. Wysocki wrote: > On Fri, Oct 20, 2023 at 1:38 PM Raag Jadav wrote: > > > > On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > > > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > > > Convert manual _UID references to use standard ACPI helpers. > > > > > > Yes, while not so obvious this is the correct replacement. > > > Reviewed-by: Andy Shevchenko > > > > I think this is the only case which would suffer from the more obvious > > behaviour, i.e. > > > > bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2) > > { > > const char *uid1 = acpi_device_uid(adev); > > > > return uid1 && uid2 && !strcmp(uid1, uid2); > > } > > > > That said, we can't be particularly sure about it's potential future users, > > especially when the usage will not be limited to just ACPI core since we're > > exporting it. > > I actually agree with this, so please switch over to the above. Will send out a v2, thanks. Andy, can I add your review for this? Raag