Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID

Andy Shevchenko
2023-10-20T10:38:22Z

On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote:
> Convert manual _UID references to use standard ACPI helpers.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> - if (!adev->pnp.unique_id ||
> - strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
> + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))

The check for NULL argument inside that API does not affect the behaviour as
otherwise it will be a crash with the current implementation.

> continue;

--
With Best Regards,
Andy Shevchenko