Re: [PATCH v1 6/8] perf: qcom: use acpi_device_uid() for fetching _UID

Rafael J. Wysocki
2023-10-20T17:22:44Z

On Fri, Oct 20, 2023 at 10:48 AM Raag Jadav <raag.jadav@intel.com> wrote:
>
> Convert manual _UID references to use standard ACPI helpers.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/perf/qcom_l3_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
> index 2887edb4eb0b..f16783d03db7 100644
> --- a/drivers/perf/qcom_l3_pmu.c
> +++ b/drivers/perf/qcom_l3_pmu.c
> @@ -742,8 +742,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_device *pdev)
>
> l3pmu = devm_kzalloc(&pdev->dev, sizeof(*l3pmu), GFP_KERNEL);
> name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "l3cache_%s_%s",
> - acpi_dev_parent(acpi_dev)->pnp.unique_id,
> - acpi_dev->pnp.unique_id);
> + acpi_device_uid(acpi_dev_parent(acpi_dev)),
> + acpi_device_uid(acpi_dev));
> if (!l3pmu || !name)
> return -ENOMEM;
>
> --

Applied as 6.7 material.

QCom perf maintainers, if you'd rather take this yourselves, please let me know.

Thanks!