From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: rafael@kernel.org, len.brown@intel.com,
mika.westerberg@linux.intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v1] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID
Date: Thu, 26 Oct 2023 06:00:25 +0300 [thread overview]
Message-ID: <ZTnWSRIr1o7RLcOl@black.fi.intel.com> (raw)
In-Reply-To: <ZTl7pDRypS3ZDIMy@smile.fi.intel.com>
On Wed, Oct 25, 2023 at 11:33:40PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 25, 2023 at 11:08:33AM +0530, Raag Jadav wrote:
> > Use acpi_dev_uid_match() for matching _UID instead of treating it
> > as an integer.
>
> NAK. See below why.
>
> ...
>
> > static void byt_pwm_setup(struct lpss_private_data *pdata)
> > {
> > - u64 uid;
> > -
> > /* Only call pwm_add_table for the first PWM controller */
> > - if (acpi_dev_uid_to_integer(pdata->adev, &uid) || uid != 1)
> > + if (!acpi_dev_uid_match(pdata->adev, "1"))
>
> _UID by specification is a type of _string_. Yet, that string may represent an
> integer number. Now, how many variants of the strings can you imagine that may
> be interpreted as integer 1? I can tell about dozens.
>
> With your change you restricted the all possible spectre of the 1
> representations to a single one. Have you checked ALL of the DSDTs
> for these platforms to say 'hey, all current tables uses "1" and
> this is not an issue'?
I'm not sure if I'm following you, this would basically invalidate every
usage of acpi_dev_hid_uid_match() helper across the driver.
Raag
next prev parent reply other threads:[~2023-10-26 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 5:38 [PATCH v1] ACPI: LPSS: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-25 5:53 ` Mika Westerberg
2023-10-25 18:04 ` Rafael J. Wysocki
2023-10-25 18:21 ` Raag Jadav
2023-10-25 18:33 ` Rafael J. Wysocki
2023-10-25 20:33 ` Andy Shevchenko
2023-10-26 3:00 ` Raag Jadav [this message]
2023-10-26 12:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTnWSRIr1o7RLcOl@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox