From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801B9179B9 for ; Tue, 31 Oct 2023 14:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="je0ejQ5o" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B308F1; Tue, 31 Oct 2023 07:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698760822; x=1730296822; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=BZtdB+YuiWI031gK4fsYrU57cmwezQDYcGMWaSImpTU=; b=je0ejQ5oa1KDqOEztqIuSngaEFfvBGjwWQ6KXMkj/HBoLmN/r+dXWNWv 7/paRUdBiDf4tzGOhvociuI5DxcBE+TVR7oZshB+hxWeppz42AHF0GMSv zDBtmI7XJi10UsqsobkcAuOljHiqTcjYbWdrhpEghIKlYFWuEsbhZQAOl 6XkRAhAW8qJIFYvKtpkhPsXQkkQDo5u4LimJiRkG+dOms6Pvv3zr/vcac MzYt2vIqgjuJcdRVw9Wn1PiqKIHOr9EEVV1GpLzJhOT5EY7aTTdOyDp23 sGsQz/gbvSPOFhv2EQj8KBpR7gy6mupfOLgZCWt/w2stQQ5QnQ7Ed9oLN A==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="373341782" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="373341782" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 07:00:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="934118568" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="934118568" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 07:00:18 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 9A8DB12033A; Tue, 31 Oct 2023 16:00:15 +0200 (EET) Date: Tue, 31 Oct 2023 14:00:15 +0000 From: Sakari Ailus To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux ACPI , LKML Subject: Re: [PATCH v2 5/6] ACPI: scan: Extract MIPI DiSco for Imaging data into swnodes Message-ID: References: <2187487.irdbgypaU6@kreacher> <7609686.EvYhyI6sBW@kreacher> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Rafael, On Tue, Oct 31, 2023 at 02:46:51PM +0100, Rafael J. Wysocki wrote: > Hi Sakari, > > On Tue, Oct 31, 2023 at 11:33 AM Sakari Ailus > wrote: > > > > Hi Rafael, > > > > On subject: > > > > s/DiSco/DisCo/ > > Huh > > Thanks for catching this! > > > On Fri, Oct 20, 2023 at 04:39:27PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Add information extracted from the MIPI DiSco for Imaging device > > > > Ditto. > > > > > properties to software nodes created during the CSI-2 connection graph > > > discovery. > > > > > > Link: https://www.mipi.org/specifications/mipi-di > > > > This URL is broken. The correct URL is: > > > > https://www.mipi.org/specifications/mipi-disco-imaging > > OK > > > > Co-developed-by: Sakari Ailus > > > Signed-off-by: Sakari Ailus > > > Signed-off-by: Rafael J. Wysocki > > > --- > > > drivers/acpi/internal.h | 1 > > > drivers/acpi/mipi-di.c | 240 +++++++++++++++++++++++++++++++++++++++++++++++- > > > > How about mipi-disco.c? I wouldn't mind having mipi-disco-imaging.c either. > > Well, mipi-disco-imaging is a bit too long and the meaning of > mipi-disco would not be clear IMO. > > What about mipi-disco-img? Seems fine to me. > > [cut] > > > > + ret = fwnode_property_count_u8(port_fwnode, "mipi-img-lane-polarities"); > > > + if (ret > 0) { > > > + unsigned long mask; > > > + unsigned int i; > > > + > > > + /* > > > + * Total number of lanes here is clock lane + data lanes. > > > + * Require that number to be low enough so they all can be > > > + * covered by the bits in one byte. > > > + */ > > > + BUILD_BUG_ON(BITS_PER_TYPE(u8) <= ARRAY_SIZE(port->data_lanes)); > > > + > > > + fwnode_property_read_u8_array(port_fwnode, > > > + "mipi-img-lane-polarities", > > > + val, 1); > > > + > > > + for (mask = val[0], i = 0; i < num_lanes + 1; i++) > > > + port->lane_polarities[i] = test_bit(i, &mask); > > > > This works only up to seven lanes. > > True, but then ACPI_DEVICE_CSI2_DATA_LANES is defined as 4. The spec has no limit and in practice 4 is relatively common while 8 exists (but is somewhat rare). I actually think it'd be a good idea to bump this to 8 already. -- Regards, Sakari Ailus