From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287531A5AC; Fri, 22 Dec 2023 13:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IXZrRXGJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703250003; x=1734786003; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fv31BzKXjf3VSQsvu13miz4XDE3frIaa7KSOGe2arrg=; b=IXZrRXGJMI1CcYlSE5Bkg3jCZcphEAwjdo4LM37pLYc/aXTu7ROGn6Gh MxDa1KIaD0aW1CqvI+Z7nCJcNnDsEvi/Ks6QYyJkdGdrKAau9O9agDD4l xT485Eo0L0XBe7fsTvfV3lZRG+yTgOIRsAYOpYOjdV4cpZJ/KLeISdJTq i2i6eKrdw5toI+qfrwPvMnXSvj2sTe53kPUYatIhTjGfM3hZLdorcokI5 +isIWtGhyJpFKKwEpNsVJJ7ILwWzYs1hWWcH7MyxBJKv7O6m3mo0YDwPK eBnczlYlZ1EuIwHDbzd7sJRTWZPMVwSLveiIkWHKkQoLzey9BpRMqO/WA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="375600610" X-IronPort-AV: E=Sophos;i="6.04,296,1695711600"; d="scan'208";a="375600610" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 05:00:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="811306267" X-IronPort-AV: E=Sophos;i="6.04,296,1695711600"; d="scan'208";a="811306267" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2023 04:59:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rGetW-0000000894Y-0bLf; Fri, 22 Dec 2023 14:44:50 +0200 Date: Fri, 22 Dec 2023 14:44:49 +0200 From: Andy Shevchenko To: Mark Hasemeyer Cc: LKML , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Rob Herring , Sudeep Holla , Daniel Scally , Frank Rowand , Greg Kroah-Hartman , Heikki Krogerus , Len Brown , "Rafael J. Wysocki" , Rob Herring , Sakari Ailus , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 20/22] device property: Modify fwnode irq_get() to use resource Message-ID: References: <20231220235459.2965548-1-markhas@chromium.org> <20231220165423.v2.20.I38ac58ab04985a404ed6551eb5813fa7841ef410@changeid> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Dec 21, 2023 at 04:46:11PM -0700, Mark Hasemeyer wrote: > > > -int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index) > > > +int fwnode_irq_get_resource(const struct fwnode_handle *fwnode, > > > + unsigned int index, struct resource *r) > > > > It's perfectly fine to replace ) by , on the previous line, no need > > to make it shorter. > > That puts the line at 115 chars? checkpatch.pl allows a maximum line > length of 100. I can bump the 'index' argument up a line and keep it > to a length of 95? Yes, the point is to leave index on the previous line and add a new one with the r. -- With Best Regards, Andy Shevchenko