From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Raul Rangel <rrangel@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
devicetree@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource
Date: Wed, 27 Dec 2023 19:24:18 +0200 [thread overview]
Message-ID: <ZYxdwrJw7_JudQXB@smile.fi.intel.com> (raw)
In-Reply-To: <20231226122113.v3.21.I38ac58ab04985a404ed6551eb5813fa7841ef410@changeid>
On Tue, Dec 26, 2023 at 12:21:25PM -0700, Mark Hasemeyer wrote:
> The underlying ACPI and OF subsystems provide their own APIs which
> provide IRQ information as a struct resource. This allows callers to get
> more information about the IRQ by looking at the resource flags. For
> example, whether or not an IRQ is wake capable.
...
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
No blank line.
...
A side note: in all files where you use ioport.h check if you actually included it.
...
> -#include <linux/types.h>
> -#include <linux/list.h>
> #include <linux/bits.h>
> #include <linux/err.h>
> +#include <linux/ioport.h>
> +#include <linux/list.h>
> +#include <linux/types.h>
Fine, but no. This file is still not using the iopoll.h.
See the forward declarations below? It should be there.
> struct fwnode_operations;
> struct device;
...
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
Same comment(s) here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-27 17:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 02/24] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by() to use resource Mark Hasemeyer
2023-12-27 17:12 ` Andy Shevchenko
2024-01-02 20:03 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 03/24] i2c: acpi: Modify i2c_acpi_get_irq() " Mark Hasemeyer
2023-12-27 17:17 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 21/24] device property: Modify fwnode irq_get() " Mark Hasemeyer
2023-12-27 17:24 ` Andy Shevchenko [this message]
2023-12-27 19:09 ` Mark Hasemeyer
2024-01-06 14:05 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 22/24] device property: Update functions to use EXPORT_SYMBOL_GPL Mark Hasemeyer
2023-12-27 17:26 ` Andy Shevchenko
2024-02-14 17:57 ` (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Bjorn Andersson
2024-02-16 11:31 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYxdwrJw7_JudQXB@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rrangel@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sudeep.holla@arm.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox