Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk

Mike Rapoport
2025-05-07T15:21:51Z

On Tue, May 06, 2025 at 06:55:44PM -0700, Andrew Morton wrote:
> On Tue, 6 May 2025 14:22:45 +0800 Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
>
> > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo
> > with the expectation that numa_cleanup_meminfo moves them to
> > numa_reserved_meminfo. There is no need for that indirection when it is
> > known in advance that these unpopulated ranges are meant for
> > numa_reserved_meminfo in support of future hotplug / CXL provisioning.
> >
> > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS
> > ranges directly.
> >
> > Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> > ---
> >
> > Changes in v2 (Thanks to Dan & Alison):
> > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws()
> > - Add comments to describe the usage of numa_add_reserved_memblk()
> > - Updating the commit message to clarify the purpose of the patch
> >
> > By the way, "LoongArch: Introduce the numa_memblks conversion" is in linux-next.
>
> So is this patch dependent upon "LoongArch: Introduce the numa_memblks
> conversion"?

Yes, the previous version of this patch failed to build on loongarch.

--
Sincerely yours,
Mike.