From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: dakr@kernel.org, djrscally@gmail.com, dvyukov@google.com,
gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
jgg@nvidia.com, kevin.tian@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, nicolinc@nvidia.com,
rafael@kernel.org, sakari.ailus@linux.intel.com,
syzbot+2ff22910687ee0dfd48e@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, yi.l.liu@intel.com
Subject: Re: [PATCH V2] software node: Prevent link creation failure from causing kobj reference count imbalance
Date: Mon, 14 Apr 2025 10:22:41 +0300 [thread overview]
Message-ID: <Z_y3wd7zur1_xUjM@smile.fi.intel.com> (raw)
In-Reply-To: <20250414071123.1228331-1-lizhi.xu@windriver.com>
On Mon, Apr 14, 2025 at 03:11:23PM +0800, Lizhi Xu wrote:
> syzbot reported a uaf in software_node_notify_remove. [1]
>
> When any of the two sysfs_create_link() in software_node_notify() fails,
> the swnode->kobj reference count will not increase normally, which will
> cause swnode to be released incorrectly due to the imbalance of kobj reference
> count when executing software_node_notify_remove().
>
> Increase the reference count of kobj before creating the link to avoid uaf.
>
> [1]
> BUG: KASAN: slab-use-after-free in software_node_notify_remove+0x1bc/0x1c0 drivers/base/swnode.c:1108
> Read of size 1 at addr ffff888033c08908 by task syz-executor105/5844
> Freed by task 5844:
> software_node_notify_remove+0x159/0x1c0 drivers/base/swnode.c:1106
> device_platform_notify_remove drivers/base/core.c:2387 [inline]
The fix looks correct to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-14 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 11:37 [syzbot] [acpi?] KASAN: slab-use-after-free Read in software_node_notify_remove syzbot
2025-04-06 13:13 ` Andy Shevchenko
2025-04-06 13:31 ` syzbot
2025-04-06 13:24 ` Andy Shevchenko
2025-04-06 14:09 ` syzbot
2025-04-08 14:54 ` Andy Shevchenko
2025-04-11 0:42 ` [PATCH] software node: Prevent link creation failure from causing kobj reference count imbalance Lizhi Xu
2025-04-14 6:20 ` Andy Shevchenko
2025-04-14 6:27 ` Andy Shevchenko
2025-04-14 7:08 ` Lizhi Xu
2025-04-14 7:16 ` Andy Shevchenko
2025-04-14 7:11 ` [PATCH V2] " Lizhi Xu
2025-04-14 7:22 ` Andy Shevchenko [this message]
2025-04-14 8:41 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_y3wd7zur1_xUjM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=nicolinc@nvidia.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=syzbot+2ff22910687ee0dfd48e@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox