* [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04
@ 2024-01-17 14:29 Mario Limonciello
2024-01-21 12:56 ` Andy Shevchenko
2024-01-22 9:06 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Mario Limonciello @ 2024-01-17 14:29 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: open list:PIN CONTROL SUBSYSTEM, open list, linux-acpi,
Andy Shevchenko, Mario Limonciello, stable, George Melikov
Spurious wakeups are reported on the GPD G1619-04 which
can be absolved by programming the GPIO to ignore wakeups.
Cc: stable@vger.kernel.org
Reported-and-tested-by: George Melikov <mail@gmelikov.ru>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3073
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 88066826d8e5..cd3e9657cc36 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1651,6 +1651,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
.ignore_interrupt = "INT33FC:00@3",
},
},
+ {
+ /*
+ * Spurious wakeups from TP_ATTN# pin
+ * Found in BIOS 0.35
+ * https://gitlab.freedesktop.org/drm/amd/-/issues/3073
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "G1619-04"),
+ },
+ .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+ .ignore_wake = "PNP0C50:00@8",
+ },
+ },
{} /* Terminating entry */
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04
2024-01-17 14:29 [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04 Mario Limonciello
@ 2024-01-21 12:56 ` Andy Shevchenko
2024-01-22 9:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-01-21 12:56 UTC (permalink / raw)
To: Mario Limonciello
Cc: Linus Walleij, Bartosz Golaszewski,
open list:PIN CONTROL SUBSYSTEM, open list, linux-acpi, stable,
George Melikov
On Wed, Jan 17, 2024 at 08:29:42AM -0600, Mario Limonciello wrote:
> Spurious wakeups are reported on the GPD G1619-04 which
> can be absolved by programming the GPIO to ignore wakeups.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04
2024-01-17 14:29 [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04 Mario Limonciello
2024-01-21 12:56 ` Andy Shevchenko
@ 2024-01-22 9:06 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2024-01-22 9:06 UTC (permalink / raw)
To: Mario Limonciello
Cc: Linus Walleij, open list:PIN CONTROL SUBSYSTEM, open list,
linux-acpi, Andy Shevchenko, stable, George Melikov
On Wed, Jan 17, 2024 at 3:29 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> Spurious wakeups are reported on the GPD G1619-04 which
> can be absolved by programming the GPIO to ignore wakeups.
>
> Cc: stable@vger.kernel.org
> Reported-and-tested-by: George Melikov <mail@gmelikov.ru>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3073
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 88066826d8e5..cd3e9657cc36 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -1651,6 +1651,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
> .ignore_interrupt = "INT33FC:00@3",
> },
> },
> + {
> + /*
> + * Spurious wakeups from TP_ATTN# pin
> + * Found in BIOS 0.35
> + * https://gitlab.freedesktop.org/drm/amd/-/issues/3073
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "G1619-04"),
> + },
> + .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
> + .ignore_wake = "PNP0C50:00@8",
> + },
> + },
> {} /* Terminating entry */
> };
>
> --
> 2.34.1
>
Queued for fixes, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-22 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-17 14:29 [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04 Mario Limonciello
2024-01-21 12:56 ` Andy Shevchenko
2024-01-22 9:06 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox