From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v1 5/6] thermal: ACPI: Constify acpi_thermal_zone_ops
Date: Thu, 8 Feb 2024 09:49:11 +0100 [thread overview]
Message-ID: <ZcSVh87SbdPCdxBY@linux.intel.com> (raw)
In-Reply-To: <13456661.uLZWGnKmhe@kreacher>
On Mon, Feb 05, 2024 at 10:18:50PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Because thermal zone operations are now stored directly in struct
> thermal_zone_device, acpi_thermal_zone_ops need not be modified by
> the thermal core and so it can be const.
>
> Adjust the code accordingly.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---
> drivers/acpi/thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -620,7 +620,7 @@ acpi_thermal_unbind_cooling_device(struc
> return acpi_thermal_bind_unbind_cdev(thermal, cdev, false);
> }
>
> -static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> .bind = acpi_thermal_bind_cooling_device,
> .unbind = acpi_thermal_unbind_cooling_device,
> .get_temp = thermal_get_temp,
>
>
>
>
next prev parent reply other threads:[~2024-02-08 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 21:12 [PATCH v1 0/6] thermal: Store trips table and ops in thermal_zone_device Rafael J. Wysocki
2024-02-05 21:14 ` [PATCH v1 1/6] thermal: core: Store zone trips table in struct thermal_zone_device Rafael J. Wysocki
2024-02-08 8:22 ` Stanislaw Gruszka
2024-02-08 19:25 ` Rafael J. Wysocki
2024-02-05 21:15 ` [PATCH v1 2/6] thermal: ACPI: Discard trip table after zone registration Rafael J. Wysocki
2024-02-08 8:22 ` Stanislaw Gruszka
2024-02-05 21:16 ` [PATCH v1 3/6] thermal: intel: Discard trip tables " Rafael J. Wysocki
2024-02-08 8:36 ` Stanislaw Gruszka
2024-02-05 21:18 ` [PATCH v1 4/6] thermal: core: Store zone ops in struct thermal_zone_device Rafael J. Wysocki
2024-02-08 8:48 ` Stanislaw Gruszka
2024-02-05 21:18 ` [PATCH v1 5/6] thermal: ACPI: Constify acpi_thermal_zone_ops Rafael J. Wysocki
2024-02-08 8:49 ` Stanislaw Gruszka [this message]
2024-02-05 21:20 ` [PATCH v1 6/6] thermal: intel: Adjust ops handling during thermal zone registration Rafael J. Wysocki
2024-02-08 8:51 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcSVh87SbdPCdxBY@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox