From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB633A1BB; Mon, 12 Feb 2024 12:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707739546; cv=none; b=NIDz8JmShTAZDATH+PZUQc0jqhu2MzdOR9nw9Ln0AsSSHY1bGbKVkOk+sCDlwbBunLHPD8iLYJ4wUR0qA13jyDuFJgiWIJrSYeQUKnW6N1k4ptTj760QFD/w6eHfTguxB4mUVl1mipLHJQKpZumv4IYvoc6IwiW52bRkOiaujnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707739546; c=relaxed/simple; bh=heqvZ8L00XwEqmJ+zKJxsEYSoUe5w3rEmtRM5dTwTnk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FdQJ3l9NmVdgXxq3EEhunPPDeKEoJ+5/0y0rwQPmntSHleKLlY1BdLMHSUVBF8ZnI412XGaDPZUbcOJgNCAomot7UAnvuwaQimOw0dY9tT9IDlgo9tSfn7AlIk/NP5T7lTnbfb/c2PO6AZ3rFeuEV2pidA9JsKGh+T73DBWFd9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EHtfTUO8; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EHtfTUO8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707739545; x=1739275545; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=heqvZ8L00XwEqmJ+zKJxsEYSoUe5w3rEmtRM5dTwTnk=; b=EHtfTUO8eVUz0AeNn8FEtwQl58quQeY5U1XDepAWyCcG0kDYKUliBDle HYwTktmgJ8P+60fQX8iD64kyT6MGE+fpULTOAPHihNi36dYo0Js5wE+1v GzynBt+mppjEYpGeYY1R+Nl5Aqrz4SsvTkSrccX+62NIclytHH7C2c9zX 6EDkdfvp6xoUzqlVVQDVv/3C7H+foePACZcUFaBJFALD+vOgmfXo/gllU 3QV3oHzAiiXI7z9bnYVGq6RaHAwZBy87Hq9zzpa1qzYlZaePlyXovZMEH XZflUouNn86KObQdtob54E54Na7KxwwtMo/HRKlmw/VBQyBhIQ3l4w7Az w==; X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="2056714" X-IronPort-AV: E=Sophos;i="6.06,263,1705392000"; d="scan'208";a="2056714" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 04:05:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10981"; a="911463620" X-IronPort-AV: E=Sophos;i="6.06,263,1705392000"; d="scan'208";a="911463620" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2024 04:05:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rZV3z-00000003t5G-0cR8; Mon, 12 Feb 2024 14:05:31 +0200 Date: Mon, 12 Feb 2024 14:05:30 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: Jonathan Cameron , linux-iio@vger.kernel.org, "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, Greg Kroah-Hartman , Daniel Scally , Heikki Krogerus , Julia Lawall , Nuno =?iso-8859-1?Q?S=E1?= , Cosmin Tanislav , Mihail Chindris , Rasmus Villemoes , Tomislav Denis , Marek Vasut , Olivier Moysan , Fabrice Gasnier , Lad Prabhakar , Dmitry Baryshkov , Marijn Suijten , Marius Cristea , Ibrahim Tilki , Peter Zijlstra , Jonathan Cameron Subject: Re: [PATCH v2 01/14] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup. Message-ID: References: <20240211192540.340682-1-jic23@kernel.org> <20240211192540.340682-2-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 12, 2024 at 08:49:23AM +0000, Sakari Ailus wrote: > On Sun, Feb 11, 2024 at 07:25:27PM +0000, Jonathan Cameron wrote: ... > > +DEFINE_FREE(fwnode_handle, struct fwnode_handle *, > > + if (!IS_ERR_OR_NULL(_T)) fwnode_handle_put(_T)) > > fwnode_handle_put() can be safely called on NULL or error pointer fwnode Yes. > so you can remove the check. No. (Technically "yes", but better "no".) This has been discussed a lot, including the LWN wrap-up about the cleanup.h. -- With Best Regards, Andy Shevchenko