public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Daniel Scally" <djrscally@gmail.com>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Julia Lawall" <Julia.Lawall@inria.fr>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
	"Mihail Chindris" <mihail.chindris@analog.com>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Tomislav Denis" <tomislav.denis@avl.com>,
	"Marek Vasut" <marex@denx.de>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.
Date: Mon, 19 Feb 2024 13:49:22 +0200	[thread overview]
Message-ID: <ZdNAQi6IlMN-quO_@smile.fi.intel.com> (raw)
In-Reply-To: <20240217164249.921878-1-jic23@kernel.org>

On Sat, Feb 17, 2024 at 04:42:34PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Sorry for the rapid resend, Andy noticed I'd messed up creating the v3 patch
> set with some updates committed in the wrong patch.
> 
> Since v3: The updates to alignment of device_for_each_child_node_scopd() were
>     in the wrong patch. Move them to patch 4 where they should always
>     have been. (thanks Andy!)
> 
> Since v2: Thanks to Sakari and Andy for reviews.
> - New first patch moving fwnode_handle_put() into property.h
> - Tweak alignment in the loop macro
> - Pick up tags.
> - scopd -> scoped typo fix in some patch descriptions.
> 
> As can be seen by the examples from IIO that follow this can save
> a reasonable amount of complexity and boiler plate code, often enabling
> additional cleanups in related code such as use of
> return dev_err_probe().
> 
> Given we are now fairly late in the cycle, I'd expect to take this
> through the IIO tree and we can make use of it elsewhere next cycle.
> 
> Note I don't have the hardware so this is compile tested only.
> Hence I'd appreciate some Tested-by tags if anyone can poke one of the
> effected drivers.
> 
> Julia Lawal has posted some nice coccinelle magic for the DT equivalents.
> Referenced from that cover letter.  Similar may help us convert more
> drivers to use this new approach, but often hand tweaking can take
> additional advantage of other cleanup.h based magic, or things like
> return dev_err_probe().
> https://lore.kernel.org/all/20240211174237.182947-1-jic23@kernel.org/

It seems you are got all necessary tags to go.
I commented with some side notes that may be addressed later on.
Up to you.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2024-02-19 11:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 16:42 [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 01/15] device property: Move fwnode_handle_put() into property.h Jonathan Cameron
2024-02-19  8:55   ` Greg Kroah-Hartman
2024-02-20  6:55   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 02/15] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup Jonathan Cameron
2024-02-19  8:55   ` Greg Kroah-Hartman
2024-02-20  6:55   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 03/15] iio: temp: ltc2983: Use __free(fwnode_handle) to replace fwnode_handle_put() calls Jonathan Cameron
2024-02-19 13:52   ` Nuno Sá
2024-02-24 11:37     ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 04/15] device property: Introduce device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19  8:56   ` Greg Kroah-Hartman
2024-02-20  6:59   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 05/15] iio: adc: max11410: Use device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19 13:54   ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 06/15] iio: adc: mcp3564: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 07/15] iio: adc: qcom-spmi-adc5: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 08/15] iio: adc: rzg2l_adc: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 09/15] iio: adc: stm32: " Jonathan Cameron
2024-02-19 11:45   ` Andy Shevchenko
2024-02-24 12:16     ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 10/15] iio: adc: ti-ads1015: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 11/15] iio: adc: ti-ads131e08: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 12/15] iio: addac: ad74413r: " Jonathan Cameron
2024-02-19 13:55   ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 13/15] iio: dac: ad3552r: " Jonathan Cameron
2024-02-19 11:46   ` Andy Shevchenko
2024-02-17 16:42 ` [PATCH v4 14/15] iio: dac: ad5770r: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 15/15] iio: dac: ltc2688: " Jonathan Cameron
2024-02-19 11:48   ` Andy Shevchenko
2024-02-19 15:48     ` Jonathan Cameron
2024-02-19 13:49   ` Nuno Sá
2024-02-19 11:49 ` Andy Shevchenko [this message]
2024-02-19 15:49   ` [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Jonathan Cameron
2024-02-24 11:49     ` Jonathan Cameron
2024-02-28 14:15       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdNAQi6IlMN-quO_@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Ibrahim.Tilki@analog.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=cosmin.tanislav@analog.com \
    --cc=djrscally@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=marex@denx.de \
    --cc=marijn.suijten@somainline.org \
    --cc=marius.cristea@microchip.com \
    --cc=mihail.chindris@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=peterz@infradead.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomislav.denis@avl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox