From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Len Brown <lenb@kernel.org>,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 4/4] of: property: fw_devlink: Add support for "post-init-providers" property
Date: Thu, 22 Feb 2024 15:32:48 +0200 [thread overview]
Message-ID: <ZddNAHqwCNR5MZc4@smile.fi.intel.com> (raw)
In-Reply-To: <20240221233026.2915061-5-saravanak@google.com>
On Wed, Feb 21, 2024 at 03:30:24PM -0800, Saravana Kannan wrote:
> Add support for this property so that dependency cycles can be broken and
> fw_devlink can do better probe/suspend/resume ordering between devices in a
> dependency cycle.
...
> - fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), 0);
> + fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np),
> + flags);
I would leave it one line despite being 83 characters long.
...
> - of_link_to_phandle(con_dev_np, phandle);
> + of_link_to_phandle(con_dev_np, phandle,
> + s->fwlink_flags);
I would leave this on one line, it's only 81 characters.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-22 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 23:30 [PATCH v3 0/4] Add post-init-providers binding to improve suspend/resume stability Saravana Kannan
2024-02-21 23:30 ` [PATCH v3 1/4] driver core: Adds flags param to fwnode_link_add() Saravana Kannan
2024-02-21 23:30 ` [PATCH v3 2/4] driver core: Add FWLINK_FLAG_IGNORE to completely ignore a fwnode link Saravana Kannan
2024-02-21 23:30 ` [PATCH v3 3/4] dt-bindings: Add post-init-providers property Saravana Kannan
2024-02-22 0:23 ` Rob Herring
2024-02-22 3:41 ` Saravana Kannan
2024-02-22 9:07 ` Krzysztof Kozlowski
2024-02-21 23:30 ` [PATCH v3 4/4] of: property: fw_devlink: Add support for "post-init-providers" property Saravana Kannan
2024-02-22 13:32 ` Andy Shevchenko [this message]
2024-02-23 0:03 ` Saravana Kannan
2024-02-23 17:37 ` Rob Herring
2024-02-22 13:34 ` [PATCH v3 0/4] Add post-init-providers binding to improve suspend/resume stability Andy Shevchenko
2024-02-23 0:02 ` Saravana Kannan
2024-02-29 18:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZddNAHqwCNR5MZc4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox