* [PATCH v1 1/1] device property: Move enum dev_dma_attr to fwnode.h
@ 2024-02-20 14:41 Andy Shevchenko
2024-02-21 7:45 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-02-20 14:41 UTC (permalink / raw)
To: Andy Shevchenko, Greg Kroah-Hartman, linux-acpi, linux-kernel
Cc: Rafael J. Wysocki, Len Brown, Daniel Scally, Heikki Krogerus,
Sakari Ailus
The struct fwnode_operations defines one of the callback to return
enum dev_dma_attr. But this currently is defined in property.h.
Move it to the correct location.
Fixes: 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/fwnode.h | 6 ++++++
include/linux/property.h | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index c1379f2d4a44..fabcd5ce084d 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -15,6 +15,12 @@
#include <linux/list.h>
#include <linux/types.h>
+enum dev_dma_attr {
+ DEV_DMA_NOT_SUPPORTED,
+ DEV_DMA_NON_COHERENT,
+ DEV_DMA_COHERENT,
+};
+
struct fwnode_operations;
/*
diff --git a/include/linux/property.h b/include/linux/property.h
index e6516d0b7d52..07fbebc73243 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -27,12 +27,6 @@ enum dev_prop_type {
DEV_PROP_REF,
};
-enum dev_dma_attr {
- DEV_DMA_NOT_SUPPORTED,
- DEV_DMA_NON_COHERENT,
- DEV_DMA_COHERENT,
-};
-
const struct fwnode_handle *__dev_fwnode_const(const struct device *dev);
struct fwnode_handle *__dev_fwnode(struct device *dev);
#define dev_fwnode(dev) \
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] device property: Move enum dev_dma_attr to fwnode.h
2024-02-20 14:41 [PATCH v1 1/1] device property: Move enum dev_dma_attr to fwnode.h Andy Shevchenko
@ 2024-02-21 7:45 ` Sakari Ailus
2024-02-23 15:22 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2024-02-21 7:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Greg Kroah-Hartman, linux-acpi, linux-kernel, Rafael J. Wysocki,
Len Brown, Daniel Scally, Heikki Krogerus
On Tue, Feb 20, 2024 at 04:41:05PM +0200, Andy Shevchenko wrote:
> The struct fwnode_operations defines one of the callback to return
> enum dev_dma_attr. But this currently is defined in property.h.
> Move it to the correct location.
>
> Fixes: 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] device property: Move enum dev_dma_attr to fwnode.h
2024-02-21 7:45 ` Sakari Ailus
@ 2024-02-23 15:22 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-02-23 15:22 UTC (permalink / raw)
To: Sakari Ailus
Cc: Greg Kroah-Hartman, linux-acpi, linux-kernel, Rafael J. Wysocki,
Len Brown, Daniel Scally, Heikki Krogerus
On Wed, Feb 21, 2024 at 07:45:22AM +0000, Sakari Ailus wrote:
> On Tue, Feb 20, 2024 at 04:41:05PM +0200, Andy Shevchenko wrote:
> > The struct fwnode_operations defines one of the callback to return
> > enum dev_dma_attr. But this currently is defined in property.h.
> > Move it to the correct location.
> >
> > Fixes: 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thank you, I will send it as a part of the series (v2).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 14:41 [PATCH v1 1/1] device property: Move enum dev_dma_attr to fwnode.h Andy Shevchenko
2024-02-21 7:45 ` Sakari Ailus
2024-02-23 15:22 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox