From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3CA208C8 for ; Mon, 11 Mar 2024 09:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150531; cv=none; b=rCmw7kGQZRBlXq35EOqMp5swiwzOyjW6aTkEafSEwffpIT1iUp8tY9WG9TwRZiVCfHeptjoKwzgqtUcWMPuY56/Y3kc5pLmvToF4J8HnyMGmmGTD1TQPIV/B1InZRobD0eiWvK4ATmFlBkv+ULYuFR50F78cd/UN0bQ9XSXcFoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710150531; c=relaxed/simple; bh=ZVZzb9k/oGOy7V8mIzyWoSmGoCb+BSj/8dDrm/Ju5qU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M701gubYQSdoFo1DrAfWxPxCC6LIOJwbO3pFM380qdseBQo3KZjWe8g2cmqG0N2JOdCNVLkzqPd8e/vHZduoeif51Vlir/jJ1RZvQOZXjug/9gGw79UTZtVqzOn944hB7tBDPROzseYUYtC//7Yo7/YYJ1DqwYiflH+Jin/HWOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iCrI5jWa; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iCrI5jWa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710150530; x=1741686530; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZVZzb9k/oGOy7V8mIzyWoSmGoCb+BSj/8dDrm/Ju5qU=; b=iCrI5jWafyCzLjNyWy8DdAoLkMWWDlhH5Yg0TN8eFiQZ0s6sEI7Chqp7 6p6FBgtMsIm6LxTllWK3C4yHNX9v+zfQz1ol5N4auYH8r5heRT2/DGPzr 7BcFFf6q4aO+6peRWHrsQ6oAcV6ZbnButRmN3WzroSqOQyHrZ0qcmayug MSvXTGcfv7BXHVrIWKFRZzK8Ipb5cbuvQONyTNnmhe52oP/2wbc0Xisef mgqVfBBGfS7BXYdvzC6aFWBpzE3WxKizVd0qO623sfTdvPnrK2AvCx+VY ELLnPHKfNt8feb677kGn+blDm4HoDBucnTvx6jIzZodtMguRt+/QFCMHk g==; X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="8619171" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="8619171" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 02:48:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="914354233" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="914354233" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 02:48:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rjcGz-0000000BaFW-1OzV; Mon, 11 Mar 2024 11:48:45 +0200 Date: Mon, 11 Mar 2024 11:48:44 +0200 From: Andy Shevchenko To: Cezary Rojewski Cc: rafael@kernel.org, linux-acpi@vger.kernel.org, robert.moore@intel.com, amadeuszx.slawinski@linux.intel.com, pierre-louis.bossart@linux.intel.com Subject: Re: [PATCH v6 2/4] ACPI: NHLT: Introduce API for the table Message-ID: References: <20240308073240.2047932-1-cezary.rojewski@intel.com> <20240308073240.2047932-3-cezary.rojewski@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sat, Mar 09, 2024 at 11:39:40AM +0100, Cezary Rojewski wrote: > On 2024-03-08 2:39 PM, Andy Shevchenko wrote: > > On Fri, Mar 08, 2024 at 08:32:38AM +0100, Cezary Rojewski wrote: ... > > + acpi.h ? > > > +#include > > > > + errno.h > > > > + minmax.h > > > > + printk.h > > + types.h > > > > > +#include ... > > > +#if IS_ENABLED(CONFIG_ACPI_NHLT) > > > > + kconfig.h ? > > > > > +#endif /* CONFIG_ACPI_NHLT */ > > Which tool helps you find out these? I want it too! My brain and my experience. Actually you can do it yourself much better than me (as the author of the code). Just read the code and check each constant and function for the header that provides it. > While I'll add the headers mentioned here, it feels weird to include > primitives such as errno.h or minmax.h. Majority of C-files found in the > kernel utilize such primitives yet the number of includes for these when > looking at the kernel as a whole is low. Which does NOT mean they are good examples. > Is there a "common defs" header in kernel? Looking for an equivalent of > 'build-essentials' package. No, there is a mess only. -- With Best Regards, Andy Shevchenko