Re: [PATCH v6 2/4] ACPI: NHLT: Introduce API for the table

Andy Shevchenko
2024-03-11T09:48:49Z

On Sat, Mar 09, 2024 at 11:39:40AM +0100, Cezary Rojewski wrote:
> On 2024-03-08 2:39 PM, Andy Shevchenko wrote:
> > On Fri, Mar 08, 2024 at 08:32:38AM +0100, Cezary Rojewski wrote:

...

> > + acpi.h ?

> > > +#include <linux/export.h>
> >
> > + errno.h
> >
> > + minmax.h
> >
> > + printk.h
> > + types.h
> >
> > > +#include <acpi/nhlt.h>

...

> > > +#if IS_ENABLED(CONFIG_ACPI_NHLT)
> >
> > + kconfig.h ?
> >
> > > +#endif /* CONFIG_ACPI_NHLT */
>
> Which tool helps you find out these? I want it too!

My brain and my experience.

Actually you can do it yourself much better than me (as the author of
the code). Just read the code and check each constant and function for
the header that provides it.

> While I'll add the headers mentioned here, it feels weird to include
> primitives such as errno.h or minmax.h. Majority of C-files found in the
> kernel utilize such primitives yet the number of includes for these when
> looking at the kernel as a whole is low.

Which does NOT mean they are good examples.

> Is there a "common defs" header in kernel? Looking for an equivalent of
> 'build-essentials' package.

No, there is a mess only.

--
With Best Regards,
Andy Shevchenko