From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Subject: Re: [PATCH v2 1/2] gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter
Date: Thu, 29 Feb 2024 17:02:57 +0200 [thread overview]
Message-ID: <ZeCcoYb8gTRGQTku@smile.fi.intel.com> (raw)
In-Reply-To: <20240229145303.3801332-2-andriy.shevchenko@linux.intel.com>
On Thu, Feb 29, 2024 at 04:51:38PM +0200, Andy Shevchenko wrote:
> Make of_gpio_get_count() take firmware node as a parameter in order
> to be aligned with other functions and decouple from unused device
> pointer. The latter helps to create a common fwnode_gpio_count()
> in the future.
>
> While at it, rename to be of_gpio_count() to be aligned with the others.
...
> struct device;
> +struct fwnode_handle;
I just realized that this should be replacement, not addition.
-struct device;
+struct fwnode_handle;
Bart, tell me if you can update, or should I send a v3?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-29 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:51 [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs Andy Shevchenko
2024-02-29 14:51 ` [PATCH v2 1/2] gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter Andy Shevchenko
2024-02-29 15:02 ` Andy Shevchenko [this message]
2024-02-29 14:51 ` [PATCH v2 2/2] gpiolib-acpi: Make acpi_gpio_count() " Andy Shevchenko
2024-03-01 6:43 ` [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs Mika Westerberg
2024-03-01 8:09 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeCcoYb8gTRGQTku@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox