From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
rafael@kernel.org, linux-acpi@vger.kernel.org,
robert.moore@intel.com, amadeuszx.slawinski@linux.intel.com
Subject: Re: [PATCH v5 1/4] ACPI: NHLT: Reintroduce types the table consists of
Date: Mon, 4 Mar 2024 21:49:03 +0200 [thread overview]
Message-ID: <ZeYlrwqDQLAcFcnl@smile.fi.intel.com> (raw)
In-Reply-To: <0d1b777e-bd95-4755-8e4c-ee37640d155b@linux.intel.com>
On Mon, Mar 04, 2024 at 10:57:39AM -0600, Pierre-Louis Bossart wrote:
> > +/* Values for link_type field above */
> > +
> > +#define ACPI_NHLT_LINKTYPE_HDA 0
> > +#define ACPI_NHLT_LINKTYPE_DSP 1
> > +#define ACPI_NHLT_LINKTYPE_PDM 2
> > +#define ACPI_NHLT_LINKTYPE_SSP 3
> > +#define ACPI_NHLT_LINKTYPE_SLIMBUS 4
> > +#define ACPI_NHLT_LINKTYPE_SDW 5
> > +#define ACPI_NHLT_LINKTYPE_UAOL 6
>
> More than half of those values are not used. Is there really any benefit
> in exposing them?
Sometimes a code is the (only) documentation. Since it's a global header and
part of ACPICA we probably better to expose all bits that are defined.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-04 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:13 [PATCH v5 0/4] ACPI: NHLT: Access and query helpers Cezary Rojewski
2024-03-04 16:13 ` [PATCH v5 1/4] ACPI: NHLT: Reintroduce types the table consists of Cezary Rojewski
2024-03-04 16:57 ` Pierre-Louis Bossart
2024-03-04 19:49 ` Andy Shevchenko [this message]
2024-03-04 20:22 ` Pierre-Louis Bossart
2024-03-04 20:34 ` Cezary Rojewski
2024-03-04 20:46 ` Pierre-Louis Bossart
2024-03-06 16:17 ` Cezary Rojewski
2024-03-06 16:30 ` Pierre-Louis Bossart
2024-03-04 16:13 ` [PATCH v5 2/4] ACPI: NHLT: Introduce API for the table Cezary Rojewski
2024-03-04 16:13 ` [PATCH v5 3/4] ACPI: NHLT: Drop redundant types Cezary Rojewski
2024-03-04 16:13 ` [PATCH v5 4/4] ACPI: NHLT: Streamline struct naming Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeYlrwqDQLAcFcnl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=cezary.rojewski@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox