From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Hamish Martin <Hamish.Martin@alliedtelesis.co.nz>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: acpi: Move storage of acpi_gpio_chip
Date: Thu, 14 Mar 2024 15:18:01 +0200 [thread overview]
Message-ID: <ZfL5CYMLY03i8q6u@smile.fi.intel.com> (raw)
In-Reply-To: <f6833616b81e4e35f561dc0ea4dae8dcd0ac026b.camel@alliedtelesis.co.nz>
On Thu, Mar 14, 2024 at 01:13:31AM +0000, Hamish Martin wrote:
> On Wed, 2024-03-13 at 13:26 +0200, Andy Shevchenko wrote:
...
> Removing the setting of the handle to invalid may be the right fix but
> I don't feel I know the code well enough to make a decision on that. It
> certainly doesn't resolve things immediately - I saw ref counting
> warnings output.
Not removing, but moving to the better place?
Can you share warnings, though?
P.S.
I'm not an expert in ACPICA and low lever of ACPI glue layer in the Linux
kernel, perhaps Rafael can suggest something better.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-14 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 3:02 [PATCH] gpiolib: acpi: Move storage of acpi_gpio_chip Hamish Martin
2024-03-13 11:21 ` Andy Shevchenko
2024-03-13 11:26 ` Andy Shevchenko
2024-03-14 1:13 ` Hamish Martin
2024-03-14 13:18 ` andriy.shevchenko [this message]
2024-03-15 0:39 ` Hamish Martin
2024-03-18 10:52 ` andriy.shevchenko
2024-04-18 19:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfL5CYMLY03i8q6u@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Hamish.Martin@alliedtelesis.co.nz \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox