From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BC722374D for ; Wed, 3 Apr 2024 03:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712116478; cv=none; b=NCWHp0lUCi7CkOlmHWLampEnyHJg8QvC+XMU4OrXFa2M/5XfwHAVxdvZxvlY6GQtAzL9uspBZoT356KglgjnZp5SRkftGyf7BpgV/yyh6dYIcteTdURNRl62Pkpd4rRjchNkyb0wwJJvKOoI7oaAoI/uTywNy+N1KRR/OyAmvr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712116478; c=relaxed/simple; bh=Bp+yP828/5PdbUhrpzXSdAnkkpi0TYMQEcNn8nQYTZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BGQcRNVQi8+6pqR+FBcLeM8fIR33suPyj+/mOAAVmuolEbYsqY6LQGeH0EqtSAVKWNSUXKkqbVhBQSOtiFmHzc2kYbp9C3jvzZg5TEcNY2g2lXzTEwKQgNvEbA2SgxoKvAIwFn/LyVy5ZWuhd4enQr9EmJ/9WLVEC+rBppS003Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=oiaat4AP; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="oiaat4AP" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6e69ae0ff44so3360154a34.1 for ; Tue, 02 Apr 2024 20:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1712116476; x=1712721276; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nDlMmweqmT2YXtYjoDTBUfL6Mkig9fvlUABwdUVfhNw=; b=oiaat4AP4tcRZZSa+bI18qqceklN1pONC1cJ1l5n2hIvHOORiH2Ad5Nlyk4HIdcIQg jRUqKh+xkLamd23/AN56e+ztY6mlZuRcffMZC0gzbRSCPzi5w1xddD7vq5zxzi+gypB3 aQFq30+WaEatbPL9NEb9dGm1ru5G/Q9/RvWO7AwQk1dTvftfImph2fjuEfG9V+bHzKKy jxUVIz3pwsYwPyoDbI+q/k2+EwbsecxJXFocr6K85Ikn1tU5rWbeBVjD9A1eJLOcC+1D y7Myl2sjCvEFc0CebehPlFpXCCuGSnx+dVeEgTjlqxAfwgJmKEIaCR2FephrfgJdQqAA ZlsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712116476; x=1712721276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nDlMmweqmT2YXtYjoDTBUfL6Mkig9fvlUABwdUVfhNw=; b=cgmJicI7AHFd8vQyW61/1CzpWgDFQP0gkO/EY8edckiLZxT9OkUKapPpRBN03JZDC2 az8aW/h/Jwyid9LokxjyrWE1TlJ4PxLxFgjjYh1SnWnBlKM5QorIqjXiA4CE4m+haHEE CKO5bl36UEdMiGyW4nFuqRHJlcJd/5t//lMjUPZ9f/1ZQxD3U9GzqbNRuukA73RNPpY+ Rld+Cu6pBUBBXyd3ckrnTZpfYleeQLIIMBtO/XjKgfrv1pumVuuNkGKEMV4mdxugwG2a FwqiYJGjFRVoDvY3Acw/LV1ckB9328e09EWhpnInnTogwKa7XyVahNEBJFt47liv3xyE U25w== X-Forwarded-Encrypted: i=1; AJvYcCVwTG5OKF+BOGYVrHtiGk+oZADuptGc32rxa/Ty6sQZ6Z/JZMqFBpI3mKSeTk5IyS0KXVcN5ZtIUSWeAzdJFWFHj9ujbXHrQrs7nQ== X-Gm-Message-State: AOJu0Yz7u4CDMPjK1ke8CXuCOT5hMJJe8py4qsCJ38YFB2lgpJRyF//Y +ntzr06ZeNtOVpFNuSTiYWqGy92uFfPozWldb8fBeifkb6chBTYNyTczWXMv1vU= X-Google-Smtp-Source: AGHT+IETkCuICm5EPgSs85v0APh8MQMZIQjKjNwLi31nnN/NIeD9KNS9g5g3rmLvIILzexgZSobE3g== X-Received: by 2002:a9d:6b94:0:b0:6e6:a32e:5f32 with SMTP id b20-20020a9d6b94000000b006e6a32e5f32mr16558369otq.29.1712116476362; Tue, 02 Apr 2024 20:54:36 -0700 (PDT) Received: from sunil-laptop ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id cm28-20020a056830651c00b006e6763530e1sm2497020otb.61.2024.04.02.20.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:54:35 -0700 (PDT) Date: Wed, 3 Apr 2024 09:24:21 +0530 From: Sunil V L To: "Luck, Tony" Cc: Haibo Xu , "Xu, Haibo1" , "ajones@ventanamicro.com" , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , "Moore, Robert" , Conor Dooley , Guo Ren , Alexandre Ghiti , Greentime Hu , Charlie Jenkins , Sami Tolvanen , Zong Li , Jisheng Zhang , Baoquan He , =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Greg Kroah-Hartman , Chen Jiahao , Arnd Bergmann , James Morse , "Russell King (Oracle)" , Evan Green , Samuel Holland , Marc Zyngier , Anup Patel , Ard Biesheuvel , Yuntao Wang , "Schofield, Alison" , Dave Hansen , "Williams, Dan J" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "acpica-devel@lists.linux.dev" Subject: Re: [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA Message-ID: References: <01cb5780041565784d459cd94a5c4f55eaa87739.1709780590.git.haibo1.xu@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 01, 2024 at 04:57:30PM +0000, Luck, Tony wrote: > >> If the firmware didn't provide the SRAT/SLIT on ACPI based systems, then > >> there will be a message "Failed to initialise from firmware" from > >> arch_acpi_numa_init(). This is not specific to RISC-V. But I am > >> wondering why should it be pr_info instead of pr_debug. > >> > > > > My understanding is maybe it just wants to expose explicit logs to > > avoid any potential bugs from FW or Kernel. > > There are lots of ACPI enabled systems that aren't NUMA (single > socket servers, desktops, laptops). Making this "pr_info()" would just > add noise to the boot on all of those. > Exactly. But this is an existing pr_info message across architectures. My suggestion is to add one more patch in this series to convert this to pr_debug unless someone has strong reason to keep it pr_info. Thanks, Sunil